Opened 5 years ago

Last modified 3 years ago

#8697 new defect

.bash_history contains traces of TBB use (Debian Linux)

Reported by: runa Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: tbb-disk-leak, needs-triage
Cc: runa, g.koppen@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Linux users who run the Tor Browser Bundle from the command line will leave traces in the .bash_history file. Is there anything we can do in this case?

Child Tickets

Change History (8)

comment:1 Changed 5 years ago by pabs

In the advice where you tell people to run it from the command-line, you can tell them to include a space before the command, then bash will not log it because the default bash configuration says to ignoreboth, which means commands starting with a space and duplicate commands.

Another option would be HISTIGNORE, but that probably would leave more traces since they would need to add it to a config file.

user@host:~$  echo bad command
bad command
user@host:~$ echo good command
good command
user@host:~$ exec bash -i
user@host:~$ tail .bash_history
echo good command
exec bash -i
user@host:~$ grep -B2 ignore /etc/skel/.bashrc 
# don't put duplicate lines or lines starting with space in the history.
# See bash(1) for more options
HISTCONTROL=ignoreboth

From the documentation:

HISTCONTROL

A colon-separated list of values controlling how commands are saved on the history list. If the list of values includes ignorespace, lines which begin with a space character are not saved in the history list. A value of ignoredups causes lines matching the previous history entry to not be saved. A value of ignoreboth is shorthand for ignorespace and ignoredups.

comment:2 Changed 5 years ago by proper

Thanks pabs!
This is a good workaround for advanced users, who read a lot documentation.

However, I don't think regular users can be expected to know and remember it.

comment:3 Changed 5 years ago by pabs

Another option would be to get something related to the TBB added to the default HISTIGNORE for bash/zsh/etc upstream and in Debian and other Linux distros.

comment:4 Changed 5 years ago by pabs

Another option would be to work with Mozilla to get TBB included in the Firefox private browsing mode. Then Tor would be included in every download of Firefox. That is a much longer term project though.

comment:5 Changed 5 years ago by gk

Cc: g.koppen@… added

comment:6 Changed 4 years ago by runa

Keywords: tbb-disk-leak added

comment:7 Changed 3 years ago by erinn

Keywords: needs-triage added

comment:8 Changed 3 years ago by erinn

Component: Tor bundles/installationTor Browser
Owner: changed from erinn to tbb-team
Note: See TracTickets for help on using tickets.