Opened 5 years ago

Closed 3 years ago

Last modified 3 years ago

#8712 closed defect (fixed)

Authorities should not vote against Fast just because they vote against Running

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: 0.2.7.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-auth easy
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by arma)

Non-active relays get stripped of their Fast flag, even if the bwauth measurements put them above the Fast threshold.

Seems to me that if enough other authorities find the relay to be Running, we shouldn't be voting against giving him the Fast flag.

Probably same with other flags like Guard, Stable, and Exit.

Child Tickets

Attachments (1)

fix-8712.patch (947 bytes) - added by piet 3 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 5 years ago by nickm

Is this in fact a change from 8435? The code before did:

  rs->is_fast = node->is_fast =
    router_is_active(ri, node, now) &&
    !dirserv_thinks_router_is_unreliable(now, ri, 0, 1);

I think this is a good-to-fix thing, but fixable in 0.2.5, since it isn't a regression and isn't a security issue

comment:2 Changed 5 years ago by nickm

Keywords: tor-auth added

comment:3 Changed 5 years ago by arma

Milestone: Tor: 0.2.4.x-finalTor: 0.2.5.x-final

looks like you're right

comment:4 Changed 5 years ago by arma

Description: modified (diff)

comment:5 Changed 4 years ago by nickm

Keywords: easy added
Milestone: Tor: 0.2.5.x-finalTor: 0.2.???

Changed 3 years ago by piet

Attachment: fix-8712.patch added

comment:6 Changed 3 years ago by piet

Not sure if I understand correctly, but this seems like a trivial fix to me..? I attached a patch.

comment:7 Changed 3 years ago by piet

Status: newneeds_review

comment:8 Changed 3 years ago by nickm

Milestone: Tor: 0.2.???Tor: 0.2.7.x-final

comment:9 Changed 3 years ago by nickm

Piet: Looks good! Merging in 0.2.7.

Roger: I'm applying this to HSDir too.

comment:10 Changed 3 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

comment:11 in reply to:  9 Changed 3 years ago by arma

Replying to nickm:

Piet: Looks good! Merging in 0.2.7.

Roger: I'm applying this to HSDir too.

Whoops!

Looks like this ticket crossed the streams with #16524.

I'm going to reopen that ticket now that it has become unfixed.

comment:12 Changed 3 years ago by nickm

Can we close this now that we fixed #16524 ?

comment:13 Changed 3 years ago by arma

Yes. In fact, this ticket has remained closed the whole time I think. :)

Note: See TracTickets for help on using tickets.