Opened 6 years ago

Closed 5 years ago

#8719 closed defect (fixed)

memory leak when we get a consensus but don't have enough certs to check it

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client 023-backport
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

==8808== 685,222 bytes in 1 blocks are definitely lost in loss record 28 of 28
==8808==    at 0x4C28BED: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64
-linux.so)
==8808==    by 0x5FDEB41: strdup (strdup.c:43)
==8808==    by 0x22114D: tor_strdup_ (util.c:240)
==8808==    by 0x1275A0: networkstatus_set_current_consensus (networkstatus.c:1718)
==8808==    by 0x1E555B: connection_dir_client_reached_eof (directory.c:1875)
==8808==    by 0x1E6F28: connection_dir_reached_eof (directory.c:2311)
==8808==    by 0x1C1496: connection_handle_read (connection.c:4119)
==8808==    by 0x11DEA0: conn_read_callback (main.c:718)
==8808==    by 0x52D8CCB: event_base_loop (in /usr/lib/x86_64-linux-gnu/libevent-2.0.so.5.1.7)
==8808==    by 0x11E834: do_main_loop (main.c:1980)
==8808==    by 0x12001D: tor_main (main.c:2696)
==8808==    by 0x5F7CEAC: (below main) (libc-start.c:228)

Child Tickets

Change History (5)

comment:1 Changed 6 years ago by nickm

Keywords: tor-client 023-backport added
Status: newneeds_review

Fix in branch "bug8719" on 0.2.3. Needs review and testing.

comment:2 Changed 6 years ago by nickm

Milestone: Tor: 0.2.4.x-finalTor: 0.2.3.x-final

Merged into 0.2.4 after a little testing; throwing into 0.2.3 for backport.

comment:3 Changed 6 years ago by arma

Nick is slightly worried there's an edge case where something goes wrong after the bugfix.

Given the trivial nature of the bug (a Tor with a brand new datadir leaks 600k), I'm inclined to leave it out of 0.2.3 and we can all stay happy.

comment:4 Changed 6 years ago by nickm

It's not just when it has a new datadir; it's when too many certs all rotate at once. I do agree that we could probably forget about this in 0.2.3 for now.

comment:5 Changed 5 years ago by nickm

Milestone: Tor: 0.2.3.x-finalTor: 0.2.4.x-final
Resolution: fixed
Status: needs_reviewclosed

Marking a batch of tickets that had been under consideration for 0.2.3 backport as fixed-in-0.2.4. There is no plan for further 0.2.3 releases.

Note: See TracTickets for help on using tickets.