Opened 6 years ago

Last modified 2 years ago

#8727 new defect

ServerTransportListenAddr validation should validate that transport-name is well-formed

Reported by: asn Owned by:
Priority: Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Minor Keywords: tor-bridge, pt, torrc, usability easy
Cc: Actual Points:
Parent ID: Points: .2
Reviewer: Sponsor:

Description

Someone put in his torrc:

ServerTransportListenAddr obfs2,obfs3 0.0.0.0:56831 0.0.0.0:56832

inspired by the format of ServerTransportPlugin. Unfortunately, this is not the correct way to use ServerTransportListenAddr. The correct way is:

ServerTransportListenAddr obfs2 0.0.0.0:56831
ServerTransportListenAddr obfs3 0.0.0.0:56832

We should at least validate that the first argument of the line is a pluggable transport name (C-identifier) to avoid stuff like "obfs2,obfs3".

Child Tickets

Change History (5)

comment:1 Changed 6 years ago by nickm

Milestone: Tor: 0.2.5.x-final → Tor: 0.2.???

comment:2 Changed 3 years ago by teor

Milestone: Tor: 0.2.??? → Tor: 0.3.???

Milestone renamed

comment:3 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.??? → Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:4 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:5 Changed 2 years ago by nickm

Keywords: torrc usability easy added
Points: → .2
Priority: Medium → Low
Severity: → Minor
Summary: ServerTransportListenAddr validation could be better → ServerTransportListenAddr validation should validate that transport-name is well-formed
Note: See TracTickets for help on using tickets.