Opened 7 years ago

Closed 7 years ago

#8788 closed defect (fixed)

We can crash on a bad resolv.conf file

Reported by: nickm Owned by:
Priority: Low Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-relay
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When we use NEXT_TOKEN in resolv_conf_parse_line, we unconditionally call evdns_nameserver_ip_add() on the result, when it might be NULL.

resolv.conf isn't adversary-controlled, so this isn't a huge deal, but we should fix it. Libevent should get this fix too.

Child Tickets

Change History (2)

comment:1 Changed 7 years ago by nickm

Status: newneeds_review

Two-minute fix: bug8788 in my public repository. Trivial. Please review.

comment:2 Changed 7 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Still trivial. Merging it.

Note: See TracTickets for help on using tickets.