Opened 7 years ago

Closed 7 years ago

#8790 closed defect (fixed)

Don't even use strcat/strcpy in the unit tests

Reported by: nickm Owned by:
Priority: Very Low Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


Using strcpy() is embarrassing, even when you happen to be using it safely. Our unit tests use it in a few places. Let's replace them with strlcpy.

Child Tickets

Attachments (1)

0001-Remove-strcpy-from-unit-tests.patch (7.0 KB) - added by arlolra 7 years ago.

Download all attachments as: .zip

Change History (3)

Changed 7 years ago by arlolra

comment:1 Changed 7 years ago by arlolra

Status: newneeds_review

See the attached.

comment:2 Changed 7 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Looks good; merged into master. Thanks!

Note: See TracTickets for help on using tickets.