Opened 6 years ago

Closed 6 years ago

#8791 closed defect (fixed)

munge_extrainfo_into_routerinfo would mishandle a non-extrainfo

Reported by: nickm Owned by:
Priority: Very Low Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client easy
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

If you could somehow make munge_extrainfo_into_routerinfo() get a document which wasn't an extrainfo, it would be in trouble, since it assumes that the relevant history lines are NUL-terminated.

For quality-of-implementation, it should check the return value of memchr().

Child Tickets

Attachments (1)

0001-Check-the-return-value-of-memchr.patch (840 bytes) - added by arlolra 6 years ago.

Download all attachments as: .zip

Change History (3)

Changed 6 years ago by arlolra

comment:1 Changed 6 years ago by arlolra

Status: newneeds_review

I assume you meant newline-terminated?

comment:2 Changed 6 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Indeed!

Added a changed file as d8f5c5b88d55c1d8893212663a7c2878f9c0c8b7; merged into master as 88a780d8990622bfc0faa3b5299d0c21012f2c41. Thanks!

Note: See TracTickets for help on using tickets.