Opened 6 years ago

Closed 6 years ago

#8798 closed defect (fixed)

Restrict valid keyword characters in metrics-db/-lib to [A-Za-z0-9-]+

Reported by: karsten Owned by:
Priority: Medium Milestone:
Component: Metrics/CollecTor Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

A few invalid server descriptors containing a "?contact" line (with ? being non-ASCII bytes) confused stem's descriptor parser (see #8049). These descriptors were not even valid according to dir-spec.txt:

KeywordChar ::= 'A' ... 'Z' | 'a' ... 'z' | '0' ... '9' | '-'

metrics-db/-lib currently don't consider these lines invalid, but only assume they contain an unknown keyword. They should instead reject these descriptors and prevent them from being included in tarballs.

Child Tickets

Change History (2)

comment:1 Changed 6 years ago by karsten

Implemented metrics-lib part in e7f93e1.

comment:2 Changed 6 years ago by karsten

Resolution: fixed
Status: newclosed

Also tested with metrics-db and deployed on yatei. Closing.

Note: See TracTickets for help on using tickets.