tbb 2.3.25-8 - Linux 64bit crashes all the time

changed milestone to %TorBrowserBundle 2.3.x-stable

added component::torbrowserbutton milestone::TorBrowserBundle 2.3.x-stable owner::erinn priority::very high resolution::fixed status::closed tbb-crash type::defect labels

I have also been experiencing this issue since updating to tbb2.3.25-8 linux 64. The vidalia logs do not show any problems or even changes when the browser crashes. The tor remains running and online. I have to manually exit and restart in order to get the browser open again. At first I thought it was potentially related to keystrokes commands, but now it is showing up randomly and often enough that it is obviously not about typing.

Trac:
Keywords: N/A deleted, TBB crashes added
Priority: normal to critical
Milestone: N/A to TorBrowserBundle 2.3.x-stable
Component: - Select a component to Tor Support
Owner: N/A to runa

How to crash 64-bit Linux tor-browser_en-US-2.3.25-8:

Unpack tor-browser-gnu-linux-x86_64-2.3.25-8-dev-en-US.tar.gz and start it.
Log on to https://wordpress.com/ (contact me for account info if you want to use the same that i used).
Press "New Post" and "Text".
Click on the window where the text is supposed to be entered. On my first three tries, FF crashed instantly. On my fourth try i managed to type a couple of letters. When clicking on the text field again, it crashed.

This was tested on a system calling itself 3.2.0-4-amd64 #1 SMP Debian 3.2.41-2+deb7u2 x86_64 GNU/Linux.

Extra info:

FF seems to be very sensitive about its extensions. Installing "RequestPolicy" makes FF extremely crashy even without running JavaScript.
Disabling NoScript and HTTPSEverywhere makes no difference.
Uninstalling ("Remove") NoScript and HTTPSEverywhere makes no difference.

Trac:
Cc: N/A to mikeperry

until the bug is fixed, this TBB is essentially non-functional. please fixit!

Trac:
Status: new to assigned
Component: Tor Support to Tor
Owner: runa to ioerror
Keywords: N/A deleted, linux 64-bit added

Trac:
Status: assigned to new

This is a TBB bug, not a bug in Tor in Tor itself.

Trac:
Component: Tor to TorBrowserButton
Status: new to assigned
Owner: ioerror to mikeperry

Our current guess is that these crash bugs are due to issues with the official Debian build machines, or with Debian's toolchain. Builds compiled on Ubuntu do not crash. At all.

If someone reproduces https://gitweb.torproject.org/torbrowser.git/blob/maint-2.4:/docs/buildmachine_setups/linux-x86.txt on a Debian machine and lets us know how crashy the result is, that would be a useful datapoint to tell us if it is specific to our build machines, or specific to Debian's compilers.

Again, following that same doc on Ubuntu does not produce crashy builds. Nor does following the Gitian instructions at https://gitweb.torproject.org/builders/tor-browser-bundle.git/blob/HEAD:/gitian/README.build.

Trac:
Keywords: TBB crashes, linux 64-bit deleted, tbb-crash added
Cc: mikeperry to mikeperry, gk

I've built TBB on a Debian system

Linux debian0 3.2.0-4-amd64 #1 SMP Debian 3.2.41-2+deb7u2 x86_64 GNU/Linux

I'm unable to crash that firefox. I've tried both in the VM where it was built and in the system where I crash my TBB from the build machine.

For a start, the list of shared libraries that firefox-bin wants matches in the two builds (output from ldd(1), that is).

What's next? Compare various objdump outputs? A complete disassembly?

The binary can be found in perdulce.tpo:~linus/firefox-bin.debian.20130604-1116 for those who might want to poke at it.

15ebbe329ae8489e84970c0acda75dfa2aeaeb2d5132152c1d93a60d83adde68 firefox-bin.debian.20130604-1116

gk suggested I'd compare about:buildconfig:

-  <link rel="stylesheet" href="buildconfig-8_files/about.css" type="text/css">
+  <link rel="stylesheet" href="buildconfig-debian0_files/about.css" type="text/css">

       <td> gcc</td>
-      <td>gcc version 4.4.5 (Debian 4.4.5-8) </td>
+      <td>gcc version 4.7.2 (Debian 4.7.2-5) </td>

--g -Os -freorder-blocks  -fomit-frame-pointer</td>
+-g -fno-omit-frame-pointer </td>

       <td> c++</td>
-      <td>gcc version 4.4.5 (Debian 4.4.5-8) </td>
+      <td>gcc version 4.7.2 (Debian 4.7.2-5) </td>

--fshort-wchar -pthread -pipe  -DNDEBUG -DTRIMMED -g -Os -freorder-blocks
-  -fomit-frame-pointer </td>
+-std=gnu++0x -pthread -pipe  -DNDEBUG -DTRIMMED -g 
+-fno-omit-frame-pointer  </td>

-<p>--enable-application=browser --enable-optimize 
+<p>--enable-application=browser --disable-optimize

So I guess I'll muck about with .mozconfig or something to at least get the flags identical.

Could somebody with access to dixie (I guess) try to figure out what local changes was used for the linux x86_64 -8 build?

Trac:
Cc: mikeperry, gk to mikeperry, gk, erinn

Got the diff between builds down to gcc/g++ version and the following g++ flags:

--fshort-wchar -pthread -pipe  -DNDEBUG -DTRIMMED -g -Os -freorder-blocks
-  -fomit-frame-pointer </td>
+-std=gnu++0x -pthread -pipe  -DNDEBUG -DTRIMMED -g -Os -freorder-blocks
+ -fomit-frame-pointer </td>

Still unable to provoke a crash.

erinn: It looks like this latest series of crashes are caused by --enable-optimize on Squeeze still. It seems like we either need to upgrade the stable build VM to Wheezy, or build with --disable-optimize again.

Trac:
Owner: mikeperry to erinn

#8895 (closed), #8939 (closed), #8930 (closed), abd #8886 (closed) are all dupped to this bug.

See also https://trac.torproject.org/projects/tor/ticket/8156#comment:24.

FWIW, I've uploaded my own build at https://people.torproject.org/~linus/downloads/TBB-0.2.3.25-8-ln5/ and can perhaps help other people building on Debian systems in case the information there doesn't help enough.

Not sure if this is related to this bug-report. But opening this site (as of 7. june) immediately crashes tor-browser. Always, this link will crash the browser.

https://magazin.spiegel.de/reader/index_SP.html#j=2013&h=23&a=97012808

Using: Tor Browser Bundle Version 2.3.25-8. Linux 64bit, Ubuntu 12.04.2 Completely stock bundle, with no customization. Completely fresh session.

Trac:
Username: monka_01

Replying to mikeperry:

erinn: It looks like this latest series of crashes are caused by --enable-optimize on Squeeze still. It seems like we either need to upgrade the stable build VM to Wheezy, or build with --disable-optimize again.

I imagine this has already occurred to other people, but: it seems like getting a non-crashy tbb out should be pretty high priority here.

I have updated bundles here: https://people.torproject.org/~erinn/qa/stable/2.3.25-9/

Please confirm that they do not crash for you and I will release them tomorrow.

The en-US bundle is still crashing for me and built with --enable-optimize. See Mike's comment (10) above.

Hmm, that's strange. The mozconfig in the source tree says --disable-optimize but the one in the build tree does indeed say --enable-optimize. Not sure if the clean target did something wrong or I did. rm -rf'ing the old tree by hand this time and rebuilding again now. Thanks, gk.

New one here. Triple checked the mozconfig: https://people.torproject.org/~erinn/qa/stable/tor-browser-gnu-linux-x86_64-2.3.25-9-dev-en-US-TEST.tar.gz sha256sum: 3d7569b880ce83722fdf1f99e73814f284ad4a8edbacaf19adc605eb0ea20dfb tor-browser-gnu-linux-x86_64-2.3.25-9-dev-en-US-TEST.tar.gz

Still the same issue: crashing and built with --enable-optimize.

Ugh, I'm sorry. Combo problem of me and the build scripts: I was using the build-firefox target which doesn't copy the newly built Firefox to the right place, so it was just using the old one. I'm sorry.

I made another one and installed a 64-bit VM to test and confirmed that it has --disable-optimize. It's here: https://people.torproject.org/~erinn/qa/stable/tor-browser-gnu-linux-x86_64-2.3.25-9-dev-en-US-TEST2.tar.gz 182a3ff7b5a707cbc84c6919f3c6514e4561c583bf754df0e8c91067f6ab4f73 tor-browser-gnu-linux-x86_64-2.3.25-9-dev-en-US-TEST2.tar.gz

I reported a "Tor crashes all the time on Windows" bug here, with a patch: https://trac.torproject.org/projects/tor/ticket/8981

After applying a binary patch to xul.dll to add the logic to return 0 if mRequest is NULL, it has not crashed for me at all after about 10 days of on-and-off use throughout each day, closing and re-opening it myself just once 2 days ago. And this is the build with optimizations enabled.

Trac:
Username: Superfluous

Replying to erinn:

Ugh, I'm sorry. Combo problem of me and the build scripts: I was using the build-firefox target which doesn't copy the newly built Firefox to the right place, so it was just using the old one. I'm sorry.

I made another one and installed a 64-bit VM to test and confirmed that it has --disable-optimize. It's here: https://people.torproject.org/~erinn/qa/stable/tor-browser-gnu-linux-x86_64-2.3.25-9-dev-en-US-TEST2.tar.gz 182a3ff7b5a707cbc84c6919f3c6514e4561c583bf754df0e8c91067f6ab4f73 tor-browser-gnu-linux-x86_64-2.3.25-9-dev-en-US-TEST2.tar.gz

Doing some cursory tests I don't get it to crash anymore. Looks good to me this time. :)

Replying to erinn:

Ugh, I'm sorry. Combo problem of me and the build scripts: I was using the build-firefox target which doesn't copy the newly built Firefox to the right place, so it was just using the old one. I'm sorry.

I made another one and installed a 64-bit VM to test and confirmed that it has --disable-optimize. It's here: https://people.torproject.org/~erinn/qa/stable/tor-browser-gnu-linux-x86_64-2.3.25-9-dev-en-US-TEST2.tar.gz 182a3ff7b5a707cbc84c6919f3c6514e4561c583bf754df0e8c91067f6ab4f73 tor-browser-gnu-linux-x86_64-2.3.25-9-dev-en-US-TEST2.tar.gz

Still crashing.

Try: https://magazin.spiegel.de/reader/index_SP.html#j=2013&h=23&a=97012808

Trac:
Username: monka_01

Finally, it seems to be fixed with Version 2.3.25-10. The link above does not crash tor browser anymore. Good work guys!

Trac:
Username: monka_01

I'm going to close this bug then. Thanks everyone.

Trac:
Resolution: N/A to fixed
Status: assigned to closed

closed

tbb 2.3.25-8 - Linux 64bit crashes all the time

Child items 0

Activity