Opened 4 years ago

Closed 4 years ago

#9009 closed defect (fixed)

TypeError: this.relay_s is undefined

Reported by: bastik Owned by: dcf
Priority: Medium Milestone:
Component: Archived/Flashproxy Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Another error I see is

Time Stamp: 01.06.2013 10:56:49
Error: TypeError: this.relay_s is undefined
Source: http://crypto.stanford.edu/flashproxy/flashproxy.js
Line: 803

This line contains

this.c2r_schedule.length > 0 this.relay_s.bufferedAmount > 0)

This might be an actual issue. I don't know why this error is logged in FF's error console.

Child Tickets

Attachments (1)

0001-Return-after-closing-websocket-in-flush.patch (1.1 KB) - added by arlolra 4 years ago.

Download all attachments as: .zip

Change History (3)

comment:1 Changed 4 years ago by arlolra

Status: newneeds_review

Looks like flush is being called when one of the sockets is undefined.

The attached should take care of it.

comment:2 Changed 4 years ago by dcf

Resolution: fixed
Status: needs_reviewclosed

Thanks. I think this bug came to light with c1768fea. The patch in comment:2 looks wrong to me, but I have committed a different fix.

How this bug manifested for me was that the ProxyPair completed callback wasn't getting called after a client completed, so the badge wouldn't turn back to the idle state.

Note: See TracTickets for help on using tickets.