Opened 4 years ago

Closed 4 years ago

#9053 closed defect (fixed)

configure broken when sh is not bash

Reported by: x3j11 Owned by:
Priority: Medium Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Commit f5cf614ed3bfdf14b16242d4f1bec086224acf4e introduces a bashism that is broken in two ways:

  • on systems where sh is not bash, such as Ubuntu which uses dash, or non-Linux, this will mean configure will break with a syntax error
  • the iteration doesn't work as expected with bash, in that only the first item is iterated on.

Using double-quotes is sufficient to use here. Attached is a patch to correct this.

Child Tickets

Attachments (1)

0001-Use-double-quotes-for-regular_mans-not-brackets.patch (1.0 KB) - added by x3j11 4 years ago.

Download all attachments as: .zip

Change History (3)

comment:1 Changed 4 years ago by x3j11

Status: newneeds_review

comment:2 Changed 4 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Thanks; applied!

Note: See TracTickets for help on using tickets.