Opened 6 years ago

Closed 5 years ago

#9059 closed enhancement (fixed)

Deprecate ClientOnly config option

Reported by: marek Owned by:
Priority: Very Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Call me old fashioned but if an option is described as "meaningless" in the manpage, maybe it shouldn't be there in the first place?

In #5005 @arma decided not to depreciate ClientOnly config option. I feel strongly that if something is "meaningless" it should be killed. Feel free to close this bug if you disagree.

Child Tickets

Attachments (2)

0001-Fix-9059-deprecate-ClientOnly-config-option.patch (5.4 KB) - added by marek 6 years ago.
givemeaningtothemeaningless-9059-0003.patch (1.5 KB) - added by mttp 5 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 6 years ago by nickm

Alternatively, we could fix the documentation to call it "unnecessary" instead of "meaningless." It *does* do something: it tells Tor to not be a server, even if the ORPort and DirPort options are set.

comment:2 Changed 6 years ago by nickm

Keywords: tor-client added
Milestone: Tor: unspecified

comment:3 in reply to:  1 Changed 6 years ago by marek

Replying to nickm:

[...] It *does* do something: it tells Tor to not be a server, even if the ORPort and DirPort options are set.

I think I may be missing something. Manpage for "DirPort" says:

If this option is nonzero, advertise the directory service on this port.

Why would user set DirPort and not want to be a server?

comment:4 Changed 6 years ago by marek

Status: newneeds_review

The patch removes ClientOnly option, not a big deal. Feel free to just close this ticket if you don't think it's a good idea.

comment:5 Changed 5 years ago by mttp

The other option would be to alter the documentation to indicate that this option isn't _completely_ meaningless. I'm not sure which of these patches is the best choice.

comment:6 Changed 5 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Tweaked mttp's patch and merged it.

Note: See TracTickets for help on using tickets.