Changes between Initial Version and Version 1 of Ticket #9069, comment 7


Ignore:
Timestamp:
Nov 6, 2013, 4:47:24 PM (5 years ago)
Author:
dcf
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #9069, comment 7

    initial v1  
    1515Right, I understand that. But I try to avoid semi-mysterious behavior like that. The flashproxy source code doesn't use double-equals anywhere for that reason. I think after I read that Douglas Crockford recommended never to use double-equals, and it made sense to me, so I started doing it.
    1616
    17 The change seems unrelated to the rest of the patch. Is it a bug that we are not currently checking against `undefined`? In what environments is it the case? If so, we should fix and document it separately.
     17The change seems unrelated to the rest of the patch. Is it a bug that we are not currently checking against `undefined`? I mean, what caused you to make the change, were your tests failing or something? If so, we should fix and document it separately. If we have to fix it here, there are probably other places we have to fix it.