Opened 6 years ago

Closed 5 years ago

#9099 closed defect (fixed)

Comment on rend_service_descriptor_t lies shamelessly

Reported by: andrea Owned by:
Priority: Very Low Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version: Tor: 0.2.4.14-alpha
Severity: Keywords: tor-hs
Cc: andrea Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

From the rend_service_descriptor_t struct in or.h:

4832   /** Bitmask: which rendezvous protocols are supported?
4833    * (We allow bits '0', '1', and '2' to be set.) */
4834   int protocols : REND_PROTOCOL_VERSION_BITMASK_WIDTH;

...but version 3 is indicated in the same way and checked for throughout the HS code.

Child Tickets

Change History (5)

comment:1 in reply to:  description Changed 6 years ago by rransom

Replying to andrea:

...but version 3 is indicated in the same way and checked for throughout the HS code.

Are you sure that's not just a bounds check? I don't know of any ‘v3’ HS protocol.

comment:2 Changed 6 years ago by rransom

Oh, you're talking about INTRODUCE cell versions.

comment:3 Changed 6 years ago by nickm

Keywords: tor-hs added

comment:4 Changed 5 years ago by nickm

Fixed in 496fe685fddcf6f914819df053856621c3090c33. Also made the field unsigned.

comment:5 Changed 5 years ago by nickm

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.