Make circuitbuild.c: global_circuitlist a proper doubly-linked list

I had a go at #4519 (moved), and instead of doing the thing described there I decided to simplify the code and make the big global_circuitlist list a nice doubly-linked list.

Trac:
Username: marek

changed milestone to %Tor: 0.2.5.x-final

added component::core tor/tor milestone::Tor: 0.2.5.x-final priority::low reporter::marek resolution::implemented status::closed tor-client type::enhancement labels

Trac:
Username: marek

0001-Don-t-access-global_circuitlist-variable-directly.-U.patch

Trac:
Username: marek

Trac:
Username: marek

0002-Fix-9108-make-global_circuitlist-a-doubly-linked-lis.patch

Trac:
Username: marek

Trac:
Username: marek
Status: new to needs_review

Argh. There's a typo in the second patch. Better use branch bug9108 on https://github.com/majek/tor.git .

Trac:
Username: marek

I think this is a good idea. I'm was confused by moving the remove code into circuit_free, but I think it does make sense there. We should audit every caller to circuit_free, of course. I was also worried about not using FOREACH_SAFE for the loop that has a local variable called "victim", but apparently that "victim" is only at risk of being marked, not freed. I should double-check this all more carefully rsn.

Replying to nickm:

I think this is a good idea. I'm was confused by moving the remove code into circuit_free, but I think it does make sense there. We should audit every caller to circuit_free, of course.

There are two of those. 429:circuit_close_all_marked and 810:circuit_free_all and wrapped in FOREACH_SAFE. I'm fairly sure there isn't a memory leak there.

Trac:
Username: marek

Trac:
Milestone: Tor: unspecified to Tor: 0.2.5.x-final
Keywords: N/A deleted, tor-client added

Okay; still looks fine to me. Merged. Thanks!

Trac:
Resolution: N/A to implemented
Status: needs_review to closed

Nickm: fyi, your ca6949ebe commit (adding a ticket9108 file) was redundant since it already had a bug9108 file.

That said, I will use (mostly) your changes text, so is fine. :)

closed

moved to tpo/core/tor#9108 (closed)