Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#9139 closed defect (fixed)

Error compiling xpi rulesets (for Firefox) in OSX

Reported by: lisacyao Owned by: micahlee
Priority: Medium Milestone: HTTPS-E 3.2.3
Component: HTTPS Everywhere/EFF-HTTPS Everywhere Version: HTTPS-E 4.0dev8
Severity: Keywords:
Cc: pde, micahlee Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When attempting to compile Firefox xpi files, the following error occurs:

lisa-yaos-macbook-pro:https-everywhere lisayao$ make
-bash: make: command not found
lisa-yaos-macbook-pro:https-everywhere lisayao$ ./makexpi.sh
Could not import lxml! Rule validation SKIPPED.
Caution: A resulting build MAY CONTAIN INVALID RULES.
Please install libxml2 and lxml to permit validation!
Validation of included rulesets completed.

Validation of rulesets with RELAX NG grammar completed.
~/https-everywhere/src/chrome/locale ~/https-everywhere
Validation of included locales completed.
Creating ruleset library...
Removing whitespaces and comments...
sed: -re: No such file or directory
sed: 1: "chrome/content/rules/de ...": command c expects \ followed by text
Crushed bytes of rulesets into
chrome/content/rules/default.rulesets passed XML validity test.
Total included rules: 3033
Rules disabled by default: 320
Created pkg/https-everywhere-3.2.2~pre.xpi

Child Tickets

Change History (3)

comment:1 Changed 7 years ago by micahlee

Owner: changed from pde to micahlee
Status: newassigned

Interesting, it looks like it actually did build the xpi file, as you can see by the last line:

Created pkg/https-everywhere-3.2.2~pre.xpi

It just skipped rule validation and some other stuff.

To not skip rule validation and other stuff you need to install some dependencies. This is true in Linux too. So I'm going to fix this just by updating the README to include build instructions for OSX and Linux.

For OSX I think the easiest thing will be to have people install homebrew (http://mxcl.github.io/homebrew/) and to install dependencies with that.

comment:2 Changed 7 years ago by micahlee

Resolution: fixed
Status: assignedclosed

comment:3 Changed 7 years ago by micahlee

Milestone: HTTPS-E 4.0dev9HTTPS-E 3.2.3
Note: See TracTickets for help on using tickets.