Untranslated strings are still removed/empty in Transifex output

It appears that untranslated strings are still empty for Firefox DTD strings, and commented out for property strings. This is causing the partially localized bundles (like Farsi) to have rendering errors. Worse, empty properties cause exceptions in Torbutton and Tor Launcher, which will alter the browser behavior in unexpected ways, possibly including interfering with important privacy settings and even proxy configuration.

Is there any way to get Transifex to provide us with a copy of the DTD and property files that actually have the English placeholders active?

added component::community/translations owner::phoul priority::very high resolution::fixed status::closed type::defect labels

Problem still exists in Torbutton - about:tor homepage - Arabic version

I can see 2 untranslated (probably the empty strings I pointed before) and they do not appear in transifex's interface.

I will contact the Transifex developers and ask about this. If Transifex can not populate empty strings with the English strings, we have two options: (1) write a script to do it, (2) only use complete translations.

Also, is this blocking #8952 (moved) in any way? If not, I will start working on this ticket later today.

I've emailed the developers again, will update when I hear back.

If they don't say anything soon, I can try setting these to   and see what explodes.

Trac:
Keywords: N/A deleted, MikePerry201307 added

Ok, I pushed a new en-US aboutTor.dtd that uses   for these two strings... Let's see if we get another transifex exception in the mail for this update (when do they pull the resource file again? is it a 1/day cronjob?)

Replying to mikeperry:

Ok, I pushed a new en-US aboutTor.dtd that uses   for these two strings... Let's see if we get another transifex exception in the mail for this update (when do they pull the resource file again? is it a 1/day cronjob?)

approx 12 - 14 hours from now.

I assume this worked? Reopen if not.

Trac:
Resolution: N/A to fixed
Status: new to closed

Trac:

Two Strings are still missing, please see the attached file.

Trac:
Status: closed to reopened
Resolution: fixed to N/A

Trac:
Keywords: MikePerry201307 deleted, MikePerry201308 added
Parent: N/A to #8952 (moved)

Trac:
Keywords: MikePerry201308 deleted, N/A added

Problem seems to be solved, today I logged into transifex and checked the Torbutton - about:tor homepage resource and I saw a couple of   so that means this is solved/fixed.

See attached: FixedStrings.png

Trac:

Actually the   thing seems to be a separate issue that got mixed in to this ticket.

The original issue is still there. I just checked out all the strings from #8952 (moved) and the partially completed strings are still emptied and commented out. This makes them unusable.

For two exmaples: https://gitweb.torproject.org/translation.git/blob/refs/heads/abouttor-homepage:/ko/aboutTor.dtd https://gitweb.torproject.org/translation.git/blob/refs/heads/torbutton-browserproperties:/ko/browser.properties

In the first file (aboutTor.dtd), the untranslated strings are all empty. This would mean that Korean users will get a completely blank about:tor page with nothing on it what-so-ever.

In the second file (browser.properties), the untranslated properties are commented out. This will cause exceptions in Torbutton and also Firefox, and will result in unexpected behavior or crashes.

The behavior we need here is for the english placeholders to be present in partially translated locales, and not commented out or empty.

I have sent another email to Transifex support about this, will update when I hear something.

Trac:
Cc: mttp to mttp, mcs, brade

Trac:
Parent: #8952 (moved) to N/A

Trac:
Cc: mttp, mcs, brade to mttp, mcs, brade, admin@insecure-complexity.com

Trac:
Owner: runa to phoul
Status: reopened to assigned

Trac:
Cc: mttp, mcs, brade, admin@insecure-complexity.com to mttp, mcs, brade

I emailed OpenITP about this issue, and they have passed the concern along to Transifex. Will followup with OpenITP during our next call (sometime this month).

During a meeting with OpenITP and Transifex today, a solution for the DTD issue was discussed / possibly found. Mike, could you please check https://gitweb.torproject.org/translation.git/blob/refs/heads/abouttor-homepage:/dz/aboutTor.dtd and let me know if this looks good to you?

All DTD strings should now include the English placeholders. If I happened to miss a resource, please let me know.

Ok, yes, this now seems true for DTD strings. We still need the same to happen for properties strings (placeholders are actually there, but commented out).

This was discussed with Transifex, however they have asked if there is some sort of specification for Mozilla's ".properties" files.

Does anything like this exist?

Yes: https://en.wikipedia.org/wiki/.properties

and

https://developer.mozilla.org/en-US/docs/XUL/Tutorial/Property_Files (section Properties)

Replying to gk:

Yes: https://en.wikipedia.org/wiki/.properties

and

https://developer.mozilla.org/en-US/docs/XUL/Tutorial/Property_Files (section Properties) Thanks gk, these have been sent along to Transifex.

Will update the ticket once I hear back.

Please see https://gitweb.torproject.org/translation.git/blob/260c137c416568f7901c03e2e352b7d6a0dc9c88:/nn/brand.properties.

If this looks correct, then I will go ahead and apply the fix to the rest of the .properties branches and mark this ticket as resolved.

Yes, that file looks fine.

All branches should now be updated.

Marking ticket as fixed, please reopen if I missed something.

Trac:
Status: assigned to closed
Resolution: N/A to fixed

Trac:
Component: User Experience/Translations to Community/Translations

closed

mentioned in issue #9438 (closed)

mentioned in issue #9838 (moved)

mentioned in issue #13893 (moved)

moved to tpo/community/l10n#9144 (closed)