Opened 6 years ago

Closed 5 years ago

Last modified 2 years ago

#9163 closed defect (wontfix)

Remove PT SOCKS argument length limit when SOCKS4 is used

Reported by: asn Owned by:
Priority: Medium Milestone:
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client pt
Cc: yawning Actual Points:
Parent ID: #10629 Points:
Reviewer: Sponsor:

Description (last modified by asn)

Repeating from comment:31:ticket:3594:

After reading #7153 and looking at faf4f6c6d1da54b0a6b0c9946112f2e448867a8f, I see that in validate_transport_socks_arguments() I reject SOCKS arguments larger than MAX_SOCKS5_AUTH_SIZE_TOTAL even if I don't know the SOCKS version that the pluggable transport proxy is going to use. Maybe this check shouldn't happen in validate_transport_socks_arguments() so that we allow large SOCKS arguments if SOCKS4a is used.

Yawning Angel experienced this limit while coding his/her SSH pluggable transport:
https://lists.torproject.org/pipermail/tor-dev/2013-June/005083.html

Unfortunately, this is not trivial to fix because when validate_transport_socks_arguments() is called we still don't know which SOCKS version the transport proxy supports.

Child Tickets

Change History (8)

comment:1 Changed 6 years ago by asn

Description: modified (diff)

comment:2 Changed 5 years ago by infinity0

Parent ID: #10629

comment:3 Changed 5 years ago by asn

FWIW a probably better long-term solution than this is at #10671.

comment:4 Changed 5 years ago by nickm

Milestone: Tor: 0.2.5.x-finalTor: 0.2.???

comment:5 Changed 5 years ago by yawning

Cc: yawning added

comment:6 Changed 5 years ago by asn

Resolution: wontfix
Status: newclosed

Proposal 229 is an even better fix for this.
Closing this one since we have better long-term solutions, and this hotfix is not easy to do either.

comment:7 Changed 2 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:8 Changed 2 years ago by nickm

Milestone: Tor: 0.3.???

Milestone deleted

Note: See TracTickets for help on using tickets.