Changes between Initial Version and Version 1 of Ticket #9163


Ignore:
Timestamp:
Jun 28, 2013, 2:37:29 PM (6 years ago)
Author:
asn
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #9163 – Description

    initial v1  
    11Repeating from comment:31:ticket:3594:
    22
    3 {{{
    4 After reading #7153 and looking at faf4f6c6d1da54b0a6b0c9946112f2e448867a8f, I see that in validate_transport_socks_arguments() I reject SOCKS arguments larger than MAX_SOCKS5_AUTH_SIZE_TOTAL even if I don't know the SOCKS version that the pluggable transport proxy is going to use. Maybe this check shouldn't happen in validate_transport_socks_arguments() so that we allow large SOCKS arguments if SOCKS4a is used.
    5 }}}
     3  After reading #7153 and looking at faf4f6c6d1da54b0a6b0c9946112f2e448867a8f, I see that in validate_transport_socks_arguments() I reject SOCKS arguments larger than MAX_SOCKS5_AUTH_SIZE_TOTAL even if I don't know the SOCKS version that the pluggable transport proxy is going to use. Maybe this check shouldn't happen in validate_transport_socks_arguments() so that we allow large SOCKS arguments if SOCKS4a is used.
     4
    65
    76Yawning Angel experienced this limit while coding his/her SSH pluggable transport: