Opened 6 years ago

Closed 6 years ago

#9175 closed defect (fixed)

Tor Browser Max OS X Lion build failing

Reported by: mcooperman Owned by: erinn
Priority: Medium Milestone:
Component: Applications/Tor bundles/installation Version:
Severity: Keywords: Firefox, TorBrowser, C-linkage, MacOs
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

trying compile from code of FIREFOX 17.0.7SER (TorBrowser)
from: https://git.torproject.org/tor-browser.git

Looking for solution/workaround to the following

git clone https://git.torproject.org/tor-browser.git
git checkout tor-browser-17.0.7esr-1
cd tor-browser

generates compiler errors of this type

  • tor-browser/js/src/jsdbgapi.h:257:1: error: 'JS_GetFrameReturnValue' has C-linkage specified, but returns

user-defined type 'jsval' (aka 'JS::Value') which is incompatible with C [-Werror,-Wreturn-type-c-linkage]

.mozconfig comes from git as:
=====================
. $topsrcdir/browser/config/mozconfig

mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj-@CONFIG_GUESS@
mk_add_options MOZ_APP_DISPLAYNAME=TorBrowser
mk_add_options MOZ_MAKE_FLAGS="-j4"
mk_add_options MOZILLA_OFFICIAL=1
mk_add_options BUILD_OFFICIAL=1

ac_add_options --enable-optimize
#ac_add_options --disable-optimize
ac_add_options --enable-official-branding
ac_add_options --enable-strip
ac_add_options --disable-tests
ac_add_options --disable-debug
ac_add_options --disable-maintenance-service
ac_add_options --disable-crashreporter
ac_add_options --disable-webrtc
================

Child Tickets

Attachments (1)

quell-clang-warnings.patch (4.1 KB) - added by gk 6 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 in reply to:  description Changed 6 years ago by mcooperman

Replying to mcooperman:

Meant to add:

build process is

cd tor-browser
/user/local/bin/autoconf213
./configure
make -f client.mk build

Also seems related to this posting I found: http://old.nabble.com/SpiderMonkey-17-Standalone-Release-td35117306.html

is there a .mozconfig option that can be set to work around this?

Changed 6 years ago by gk

Attachment: quell-clang-warnings.patch added

comment:2 Changed 6 years ago by gk

Component: - Select a componentTor bundles/installation
Owner: set to erinn

That's not a Torbrowser issue but a Mozilla one. Applying that patch with

patch -tp1 < quell-clang-warnings-patch

should fix it.

comment:3 in reply to:  description Changed 6 years ago by mcooperman

Resolution: fixed
Status: newclosed

that seems to have resolved that issue. thank you.

Note: See TracTickets for help on using tickets.