Opened 12 years ago

Closed 10 years ago

Last modified 8 years ago

#919 closed defect (fixed)

If you hup tor while it's hibernating, it rebinds its ports

Reported by: arma Owned by:
Priority: Low Milestone: Tor: 0.2.2.x-final
Component: Core Tor/Tor Version: 0.2.0.31
Severity: Keywords: easy
Cc: arma, nickm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by nickm)

It looks like retry_listeners() and retry_all_listeners() do not care
whether we're hibernating. In main.c, retry-all-listeners is only called if

if (!we_are_hibernating() && time_to_check_listeners < now) {

whereas in config.c it does not check if we_are_hibernating. Sounds like that's
the place to fix it.

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Attachments (1)

0001-Bug-919-Don-t-rebind-ports-if-we-receive-SIGHUP-whil.patch (1.5 KB) - added by cjb 10 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 10 years ago by nickm

Milestone: post 0.2.1.xTor: 0.2.2.x-final

comment:2 Changed 10 years ago by nickm

Description: modified (diff)
Keywords: easy added

comment:3 Changed 10 years ago by cjb

That's interesting. We actually used to check whether we were hibernating until commit 7c6679d8dc260f6fb6f183c83b0d058b3ba0852c in 2005, which was ostensibly cleaning up config code. So, this was a regression back in 0.1.1.6-alpha. Patch to return us to the old behavior attached.

comment:4 Changed 10 years ago by cjb

Status: newneeds_review

comment:5 Changed 10 years ago by Sebastian

Looks fine to me.

comment:6 Changed 10 years ago by nickm

Resolution: Nonefixed
Status: needs_reviewclosed

Likewise. Merging.

comment:7 Changed 8 years ago by nickm

Component: Tor RelayTor
Note: See TracTickets for help on using tickets.