Opened 7 years ago

Closed 7 years ago

#9256 closed defect (wontfix)

Freebsd 4 compilation issues in 0.2.4 and 0.2.5

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client freebsd4
Cc: grarpamp Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In #3894, grarpamp reports:

FreeBSD 4.x i386 2.95.4
tor-0.2.3.25
control.c: In function `handle_control_attachstream':
control.c:2642: warning: `exit_digest' might be used uninitialized in this function
routerparse.c: In function `router_parse_list_from_string':
routerparse.c:1168: warning: `signed_desc' might be used uninitialized in this function

tor-0.2.4.15
src/or/circuitmux.c: In function `circuitmux_detach_circuit':
src/or/circuitmux.c:1011: warning: `last_searched_direction' might be used uninitialized in this function
src/or/control.c: In function `handle_control_attachstream':
src/or/control.c:2684: warning: `exit_digest' might be used uninitialized in this function
src/or/entrynodes.c: In function `entry_guards_parse_state':
src/or/entrynodes.c:1225: warning: use of l' length character with f' type character
src/or/entrynodes.c:1225: warning: use of l' length character with f' type character
src/or/entrynodes.c:1290: warning: use of l' length character with f' type character
src/or/entrynodes.c:1290: warning: use of l' length character with f' type character
src/or/routerparse.c: In function `router_parse_list_from_string':
src/or/routerparse.c:973: warning: `signed_desc' might be used uninitialized in this function
src/or/status.c: In function `log_heartbeat':
src/or/status.c:121: warning: .' not followed by *' or digit in format

master 6848e29
src/or/circuitmux.c: In function `circuitmux_detach_circuit':
src/or/circuitmux.c:1082: warning: `last_searched_direction' might be used uninitialized in this function
src/or/control.c: In function `handle_control_attachstream':
src/or/control.c:2685: warning: `exit_digest' might be used uninitialized in this function
src/or/entrynodes.c: In function `entry_guards_parse_state':
src/or/entrynodes.c:1229: warning: use of l' length character with f' type character
src/or/entrynodes.c:1229: warning: use of l' length character with f' type character
src/or/entrynodes.c:1294: warning: use of l' length character with f' type character
src/or/entrynodes.c:1294: warning: use of l' length character with f' type character
src/or/routerparse.c: In function `router_parse_list_from_string':
src/or/routerparse.c:973: warning: `signed_desc' might be used uninitialized in this function
src/or/status.c: In function `log_heartbeat':
src/or/status.c:121: warning: .' not followed by *' or digit in format

Child Tickets

Change History (4)

comment:1 Changed 7 years ago by nickm

My first inclination is to ask, "Is anybody actually trying to use Tor on FreeBSD 4?" On #3894, grarpamp said: "It probably only exists in small embedded systems these days."

grarpamp, are you actually trying to run Tor on FreeBSD 4, and do you know anybody who is? According to what I can find out, it hasn't been supported for about 6 or 7 years now (http://lists.freebsd.org/pipermail/freebsd-security/2006-October/004111.html). Generally, when the distribution stops offering security patches, we stop making sure Tor works there. (That's why we don't support Windows 2000 or OSX 10.5.)

That said, I'd be fine taking clean patches to fix up Tor on FreeBSD 4, but if it's really unsupported and not getting security patches, I'm probably not going to write them myself. Is anybody else interested?

comment:2 Changed 7 years ago by nickm

Cc: grarpamp added

comment:3 Changed 7 years ago by grarpamp

you actually trying to?

No. Only as a cursory/courtesy check for tpo on the nas.

anybody who is?

There were some small form factor wifi people running it 1y+ ago, I gather they have migrated.

Yes, anything older than freebsd8+ has long since been officially unsupported and freebsd4 marked the last of a design line/era. It does compile (with noise) and run there, so that should carry any stragglers.

Given the announcement to test 0.2.4.x-rc, I'd certainly close this ticket forever if no unaffiliated contributers pop up within a week or so.

comment:4 Changed 7 years ago by nickm

Resolution: wontfix
Status: newclosed

Okay, I'm going to tentatively close this as won't-fix. If somebody shows up who has some desperately legitimate need to run a very recent tor on their very non-upgraded freebsd, they can re-open this.

Note: See TracTickets for help on using tickets.