Opened 6 years ago

Closed 6 years ago

#9265 closed defect (implemented)

test_pt_parsing doesn't check managed_proxy_t contents

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client testing easy
Cc: asn Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Have a look at test_pt_parsing(). It looks to see whether parse_*() succeed or fail... but it doesn't actually check that they store the right results in managed_proxy_t! That's not what a unit test should do.

Child Tickets

Change History (2)

comment:1 Changed 6 years ago by asn

Status: newneeds_review

How about bug9265 in https://git.torproject.org/user/asn/tor.git?

comment:2 Changed 6 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Thanks, merged!

Note: See TracTickets for help on using tickets.