Opened 6 years ago

Last modified 2 years ago

#9290 new defect

Use something other than "known relay" to decide on rate in connection_or_update_token_buckets_helper() on authorities

Reported by: nickm Owned by:
Priority: Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-relay, bandwidth, tor-dirauth
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

On #tor-dev , Beeps says:

13:18 < Beeps> connection_or_update_token_buckets_helper() will not limit speed
               if relay knows desc. You can upldoad desc to any auth. Before
               limit speed you need protect all auths or limit speed for them.
               5 of them are victims for cheaters for now.

In other words, anybody can get the higher limit from an authority by uploading a descriptor with their ID, whether they're really a relay or not. That's annoying.

One fix would be to change the behavior of connection_or_digest_is_known_relay to require that the relay be present in the consensus. (Would this hurt bandwidth measurement?)

Child Tickets

Change History (5)

comment:1 Changed 6 years ago by nickm

Milestone: Tor: 0.2.5.x-finalTor: 0.2.???

comment:2 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:3 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:4 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:5 Changed 2 years ago by nickm

Keywords: tor-dirauth added
Priority: MediumLow
Severity: Normal
Summary: Use something other than "known relay" to decide on rate in connection_or_update_token_buckets_helper()Use something other than "known relay" to decide on rate in connection_or_update_token_buckets_helper() on authorities
Note: See TracTickets for help on using tickets.