Changes between Initial Version and Version 1 of Ticket #9316, comment 34


Ignore:
Timestamp:
Aug 13, 2019, 1:22:34 AM (2 months ago)
Author:
phw
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #9316, comment 34

    initial v1  
    66> There were some changes that I couldn't track how they relate to the metrics feature, perhaps they snuck in from some other changes being made to bridgedb? Otherwise it looks really good!
    77[[br]]
    8 Right, I split the branch into three commits, to make it less confusing. [https://github.com/NullHypothesis/bridgedb/commit/0d5ed52e5906260e142ef9cfa12752810fd1ffa2 0d5ed52e] fixes the broken download of Tor exit relays, [https://github.com/NullHypothesis/bridgedb/commit/85a69d1be3f14a8ba0c5ba8e4840e40214217941 85a69d1b] updates a comment, and [https://github.com/NullHypothesis/bridgedb/commit/91d12652065f7912a6a8fe12bee27fc9dcaeb842 91d12652] implements the metrics feature.
     8Right, I split the branch into three commits, to make it less confusing. [https://github.com/NullHypothesis/bridgedb/commit/0d5ed52e5906260e142ef9cfa12752810fd1ffa2 0d5ed52e] fixes the broken download of Tor exit relays, [https://github.com/NullHypothesis/bridgedb/commit/85a69d1be3f14a8ba0c5ba8e4840e40214217941 85a69d1b] updates a comment, and [https://github.com/NullHypothesis/bridgedb/commit/5cde59d9ccafdb248ca8aa9c1c9abbfe2edb5dc6 5cde59d9] implements the metrics feature.
    99[[br]]
    1010> There might be an unchecked failure case [https://github.com/NullHypothesis/bridgedb/blob/d1a70dee2ca476b0819a1cb24212215e31c755d6/bridgedb/distributors/moat/server.py#L741 here] with the moat reporting for when we don't have any bridge lines to return. It's not really a failure of the system though so much as a lack of bridges so I'm not sure how we'd want to count that.
     
    1313
    1414We probably also want BridgeDB-centric metrics such as "number of bridges per ring" and "number of requests that were answered with 0 bridges". I suggest that we discuss these in a separate ticket, ok?
     15
     16Edit: Changed URLs to git commits.