Opened 6 years ago

Closed 6 years ago

#9354 closed defect (fixed)

NumDirectoryGuards should track NumEntryGuards

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

If you change NumEntryGuards to 1, your Tor will still contact 3 relays for directory information, since you didn't realize you had to set NumDirectoryGuards too. This fails the 'no surprises' principle.

At the same time, we have this check:

  if (options->UseEntryGuards && ! options->NumEntryGuards)
    REJECT("Cannot enable UseEntryGuards with NumEntryGuards set to 0");

but no corresponding check for "UseEntryGuardsAsDirGuards 1 but NumDirectoryGuards 0".

I think the right behavior should be to treat NumDirectoryGuards 0 as "use the value from numentryguards", and change that to the default.

Bug encountered by Isis.

Child Tickets

Change History (2)

comment:1 Changed 6 years ago by arma

Status: newneeds_review

see my bug9354 branch (on maint-0.2.4)

comment:2 Changed 6 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Looks good! Merging this.

Note: See TracTickets for help on using tickets.