Opened 11 years ago

Last modified 8 years ago

#941 closed defect (Fixed)

circuit event lines sometimes miss verbose names

Reported by: arma Owned by:
Priority: Low Milestone: 0.2.1.x-final
Component: Core Tor/Tor Version:
Severity: Keywords:
Cc: arma, nickm, edmanm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


In my Vidalia logs
Mar 12 20:18:31.186 [notice] QtWarningMsg: torcontrol: Improperly formatted
circuit: '16 EXTENDED $5A583B838FDC22246E046E1D4E108F41EFBAD175'

edmanm:#vidalia> those circ events are spec compliant, but they're annoying
since they don't include the nickname, even when you ask for verbose_names.
edmanm:#vidalia> i don't know why tor includes that with some circ events and
not others.

edmanm> when i say "usefeature verbose_names", tor gives me hops in circ
events as either "$id=nickname" for named relays or "$id~nickname" for
non-named relays.
edmanm> except in some cases, like the one you pasted above, all i get is
edmanm> that's the same format you get when you don't specify 'usefeature
verbose_names'. (i.e. just $id for non-named relays or just the nickname for
named relays)

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Change History (5)

comment:1 Changed 11 years ago by nickm

So, this is partially a bug and partially notabug and partially just odd.

The bug part was that when we knew a router from only a routerstatus, not a routerinfo, we wouldn't generate a
verbose nickname. I'm fixing this now.

The not-a-bug part is that if we ever have a circuit through a router where we lack both a routerstatus and a
routerinfo, we just won't give a nickname period. Controllers need to be able to handle this case, I think.
[Check out circuit_list_path_impl() for the gory details.]

The just plain odd part is ... when do we have a circuit where we lack both a routerstatus and a routerinfo? I
guess this can happen with one-hop directory connections... and maybe with bridges?

comment:2 Changed 11 years ago by nickm

In fact, control-spec.txt indicates that the nickname part is optional:

LongName = Fingerprint [ ( "=" / "~" ) Nickname ]

I'll patch that too to make it more explicit.

comment:3 Changed 11 years ago by nickm

I think r19078 should be somewhat improved. The rest is, I think, notabug.

comment:4 Changed 11 years ago by nickm

flyspray2trac: bug closed.

comment:5 Changed 8 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.