Opened 11 years ago

Last modified 11 years ago

#950 closed defect (Fixed)

disabling torbutton clears preferences instead of resetting

Reported by: ilf Owned by:
Priority: Low Milestone:
Component: Applications/Torbutton Version: 1.2.0
Severity: Keywords:
Cc: ilf Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I have a custom value in the general.useragent.override preference.
When enabling torbutton, it changes this value to "Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.16) Gecko/20080702 Firefox/2.0.0.16", which is intended and fine.
But when disabling torbutton again, it clears this value instead of resetting it to what's been in there before.

Related: when disabling torbutton, it also ENABLES the settings:

  • privacy -> Remember what I enter in forms and the search bar
  • privacy -> Remember what I've downloaded
  • security -> Remember passwords for sites

Since I have these disabled also before enabling torbutton, enabling them confuses me and causes work.

I think torbutton should save the values of settings it changes and reset them to those instead of whatever values it thinks it should.

Thanks and keep up the awesome work!

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Attachments (1)

torbutton-1.2.3-pre9.xpi (338.6 KB) - added by mikeperry 10 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 10 years ago by mikeperry

Ok, I've attached a fix for this in the attachments tab. Please let me know if it works for you, especially
for all cases of changing your user agent and settings.

Changed 10 years ago by mikeperry

Attachment: torbutton-1.2.3-pre9.xpi added

comment:2 Changed 10 years ago by ilf

Works like a charm, thanks!

comment:3 Changed 10 years ago by mikeperry

flyspray2trac: bug closed.
Will appear in 1.2.3

Note: See TracTickets for help on using tickets.