Status bar icon unnecessarily large

As of HTTPS Everywhere 3.3.2, the icon in the Firefox status bar is made unnecessarily large by the number indicating how many sites were matched. This makes the entire status bar larger than normal. It would be very nice if there was a way to either disable the number, or have some other indicator (such as graying out the icon when no rules as active, as Stylish does).

Trac:
Username: EvilHom3r

added component::https everywhere/eff-https everywhere owner::pde priority::medium reporter::EvilHom3r resolution::fixed severity::normal status::closed type::defect labels

Trac:
Username: EvilHom3r

3.3.1 vs 3.3.2

Trac:
Username: EvilHom3r

Is this a duplicate of #9506 (moved)?

Hi, that would be due to these changes that we just pulled from master to stable to make the icon show the number of applied rules: https://trac.torproject.org/projects/tor/attachment/ticket/9506/css.diff

Unfortunately graying out the icon won't work because we also pulled in a change to make the icon gray when HTTPS Everywhere is disabled.

This seems like it's bothersome enough to people that we should fix it. I will ping nullishzero about this via email since I can't add people to the cc.

Let me see what I can do; I have somewhat of an idea what may be causing this.

My solution right now will be to fix the size of the icon so that it respects the user's toolbar settings. Eventually, I want to add a feature that would allow the user to disable the ruleset counter.

Trac:
Username: nullishzero

Trac:
Username: nullishzero
Cc: N/A to nullishzero@gmail.com

Trac:
Username: rohieb
Cc: nullishzero@gmail.com to nullishzero@gmail.com, rohieb@rohieb.name

Please pull and merge https://github.com/nullishzero/https-everywhere to master

I have tested the fix on a few setups, but I strongly recommend not pushing this to stable until a bit more testing is done.

Trac:
Username: nullishzero

nullishzero's fix got rid of the unnecessary icon padding on my setup (FF23, Ubuntu 12.04).

Trac:
Status: new to needs_review

Fix has been merged into upstream master.

Trac:
Username: nullishzero

This problem is still here on addons.mozilla.org. It happens with other Firefox addons on Linux, like ModifyHeaders http://stackoverflow.com/questions/11085234/toolbar-icon-height-issue-with-firefox-on-linux. I fixed MofifyHeaders bug myself and tried to fix HTTPSEverywhere but without luck. Please share the code modifications and update to a new version.

Trac:
Username: baptx

Problem fixed with version 3.4.5. Don't know what part of the code was wrong btw.

Trac:
Username: baptx

Trac:
Status: needs_review to closed
Reviewer: N/A to N/A
Resolution: N/A to fixed
Sponsor: N/A to N/A
Severity: N/A to Normal

closed

mentioned in issue #9526 (moved)

mentioned in issue #9534 (moved)

mentioned in issue #9535 (moved)

moved to tpo/applications/https-everywhere-eff#9511 (closed)