option to disable counter in navigation bar icon

After upgrading either Firefox to v23.0.1 or HTTPS-Everywhere to 3.4.1, the counter besides the addon's button in the navigation bar looks a bit weird. Overlaid partially over the icon itself with an ugly box, see attached screenshot.

Would it please be possible to implement an option to disable the counter, or to make it look nicer? Like Ghostery for example, even though it's not a very popular addon by itself ;-)

added component::https everywhere/eff-https everywhere owner::pde parent::9511 priority::low resolution::fixed severity::normal status::closed type::enhancement version::https-e 3.4.1 labels

Trac:

Hi, we've gotten a bunch of requests about this. Setting the parent to #9511 (moved).

nullishzero pushed a change to the css which needs testing, since it might fix this issue. https://github.com/nullishzero/https-everywhere/commit/d5379c401e4d895e7c951fe0f7ca397404c85f6c

Trac:
Parent: N/A to #9511 (moved)

. . . Although it seems like the fix above doesn't affect the counter size, so maybe a separate feature to disable the counter entirely would be useful.

Thankfully the codefix for the extra padding was rather trivial :)

The extra padding was due to the 'toolbarbutton-1' and 'chromeclass-toolbar-additional' treating the XBL binding as the parent, which wasn't required/needed since these classes were already defined in the XBL file. Frankly, XBL sometimes feels like black magic to me.

I underestimated how fast this counter code was going to be merged to stable. I will try to push out an option to disable the counter soon, and once I'm done, I'll see if I can 'beautify' the ruleset counter (depending on how much time I have of course).

Trac:
Username: nullishzero
Cc: N/A to nullishzero@gmail.com

Code for disabling counter: https://github.com/nullishzero/https-everywhere/tree/issue9535

Please review and merge to master.

Trac:
Username: nullishzero
Status: new to needs_review

Merged latest master to https://github.com/nullishzero/https-everywhere/tree/issue9535

Trac:
Username: nullishzero

Hi nullish!

I'm super sorry I missed all of this while I was on sabbatical. I feel like this is too obscure a setting to have in the toolbar menu. Either it should be in the "HTTPS Everywhere preferences" XUL window or it should just be an about:config button that people who really care can set.

Aside from that, the patch looks good.

Hi nullishzero,

I was looking at the code for updating the counter and noticed that updateRulesetsApplied calls alist.populate_list, which calls rewrittenURI, which does a lot of work. I don't think we should be calling this every time a user switches tabs. :(

Can you look into making updateRulesetsApplied more lightweight, perhaps with some sort of caching?

-Yan

pde,

No worries. If the toolbar menu might not be the right place, let's go with the about:config option. If enough people make a fuss, we can always add an option in the XUL window.

yan,

Yeah, it occurred to me that alist.populate_list is rather inefficient (I stress tested the code to make sure it wasn't a show stopper). I initially had it cached but ran into issues where the counter might not get properly updated if the website loaded any new sites via javascript that potentially applied more rules.

I do think efficiency here should definitely be improved, and I will look into a better method.

Trac:
Username: nullishzero

Trac:
Severity: N/A to Normal
Reviewer: N/A to N/A
Sponsor: N/A to N/A
Status: needs_review to closed
Resolution: N/A to fixed

closed

moved to tpo/applications/https-everywhere-eff#9535 (closed)