Opened 7 years ago

Closed 7 years ago

#9588 closed defect (fixed)

Minor spec clarificaiton for TRANSPORT_LAUNCHED events

Reported by: atagar Owned by:
Priority: Very Low Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version:
Severity: Keywords:
Cc: asn Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Hi George, just added stem support for your new TRANSPORT_LAUNCHED events. All looks well, just a minor bit of fuzziness in the spec...

11:20 < atagar> asn: Minor spec confusion. Your event redefines Address. Earlier in the control-spec.txt an 'Address' is defined as...
11:20 < atagar> Address = ip4-address / ip6-address / hostname   (XXXX Define these)
11:21 < atagar> ... and your event defines it as...
11:21 < atagar> Address = The IP address on which it is listening for connections
11:22 < atagar> The later disallows hostnames, but doesn't specify if it's just IPv4 or also IPv6. Also, it would probably be good to pick an identifier other than 'Address' to avoid matching the earlier definition.
11:23  * atagar decides to guess it's "ipv4 or ipv6 but not hostnames" until clarified

Cheers! -Damian

Child Tickets

Change History (3)

comment:1 Changed 7 years ago by nickm

Cc: asn added
Milestone: Tor: 0.2.5.x-final

comment:2 Changed 7 years ago by asn

Status: newneeds_review

Please see branch bug9588 in https://git.torproject.org/user/asn/torspec.git for a spec clarification on this.
https://gitweb.torproject.org/user/asn/torspec.git/shortlog/refs/heads/bug9588

Thanks for pointing this out, atagar!

For what it's worth, you read between the lines correctly; it was waiting for an IPv4 or IPv6 address -- not a hostname.

comment:3 Changed 7 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

merged

Note: See TracTickets for help on using tickets.