Opened 10 years ago

Last modified 7 years ago

#959 closed defect (Fixed)

bodylen 501408 larger than 499999. Failing.

Reported by: arma Owned by:
Priority: Low Milestone:
Component: Core Tor/Tor Version: 0.2.1.13-alpha
Severity: Keywords:
Cc: arma, nickm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Tor directory authorities are refusing uploaded votes, since the votes
have grown larger than 500KB.

Mar 26 23:50:03.015 [warn] bodylen 501408 larger than 499999. Failing.
Mar 26 23:50:03.015 [warn] Invalid input from address '86.59.21.38'. Closing.

moria1 (and others) have been doing this for the past 5 days, and the world
hasn't exploded. I think that's because the uploads are refused:

/ Maximum size, in bytes, for any directory object that we're accepting

  • as an upload. */

#define MAX_DIR_UL_SIZE 500000

but then Tor falls back to fetching the votes, which succeeds:
/ Maximum size, in bytes, for any directory object that we've downloaded. */
#define MAX_DIR_DL_SIZE MAX_BUF_SIZE

Currently there are only four items that are uploaded:
/ A connection to a directory server: upload a server descriptor. */
#define DIR_PURPOSE_UPLOAD_DIR 8
/
A connection to a directory server: upload a rendezvous

  • descriptor. */

#define DIR_PURPOSE_UPLOAD_RENDDESC 9
/ A connection to a directory server: upload a v3 networkstatus vote. */
#define DIR_PURPOSE_UPLOAD_VOTE 10
/
A connection to a directory server: upload a v3 consensus signature */
#define DIR_PURPOSE_UPLOAD_SIGNATURES 11

And once UPLOAD_DIR has finished, we limit the size of the objects we're
willing to add, in case we're attacked.

I think the right fix is to set MAX_DIR_UL_SIZE to MAX_BUF_SIZE also. Any
other fix will mean we reopen this bug in 18 months.

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Change History (4)

comment:1 Changed 10 years ago by nickm

I suppose so, yes. It would also be good if in 0.2.2.x we could accept compressed uploads.

comment:2 Changed 10 years ago by arma

Fixed in r19194.

Also fixed a different bug that it uncovered, in r19189.

comment:3 Changed 10 years ago by arma

flyspray2trac: bug closed.

comment:4 Changed 7 years ago by nickm

Component: Tor RelayTor
Note: See TracTickets for help on using tickets.