Opened 7 years ago

Closed 7 years ago

#9596 closed defect (fixed)

POLICY_BUF_LEN should be longer

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-relay
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


Now that we can have, and need to write, IPv6 policy items, we need to increase the length of POLICY_BUF_LEN, since the longest possible exit policy item is now
"accept6 [ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff]/128:65535-65535\n".

Fortunately, we use POLICY_BUF_LEN in only a few places, none of which make this super harmful, but it could prevent us from formatting some log messages correctly.

Child Tickets

Change History (3)

comment:1 Changed 7 years ago by nickm

Status: newneeds_review

Please review the (simple) bug9596 branch in my public repository. I chose "72" as the limit, even though "67" would have been sufficient.

comment:2 Changed 7 years ago by asn

Looks good to me.

comment:3 Changed 7 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Thanks for the review; merged it into 0.2.4 and later.

Note: See TracTickets for help on using tickets.