Opened 6 years ago

Closed 3 years ago

#9666 closed defect (wontfix)

Autogen error for autoreconf could be more helpful

Reported by: atagar Owned by:
Priority: Very Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: easy tor-client
Cc: rl1987@… Actual Points:
Parent ID: Points: small
Reviewer: Sponsor:

Description

Hi, minor nitpick but when I pulled and re-ran tor's autogen it failed due to a new dependency...

atagar@odin:~/Desktop/tor/tor$ ./autogen.sh 
Can't exec "libtoolize": No such file or directory at /usr/bin/autoreconf line 196.
Use of uninitialized value in pattern match (m//) at /usr/bin/autoreconf line 196.

This is all well and good, but we usually provide a more helpful error message (preferably including the debian package the person needs). The following did the trick for me...

sudo apt-get install dh-autoreconf

Cheers! -Damian

Child Tickets

Change History (5)

comment:1 Changed 6 years ago by nickm

Keywords: tor-client added
Milestone: Tor: unspecified

comment:2 Changed 6 years ago by rl1987

Status: newneeds_information

What should the error message say? Printing the name of Debian package probably isn't the best solution since Tor can be compiled on other systems than Debian. "Please install autotools" is probably too vague.

Besides, we should be addressing the case where, say, aclocal is missing and should be installled.

comment:3 Changed 6 years ago by rl1987

Cc: rl1987@… added

comment:4 Changed 4 years ago by nickm

Points: small

comment:5 Changed 3 years ago by nickm

Resolution: wontfix
Severity: Normal
Status: needs_informationclosed

I suppose that we could add a bunch of stuff to 'autogen.sh' to detect various missing autotools components, and detect the operating system, and prompt the user telling them how to get the right packages ... but I dunno. It seems like a fairly large amount of fiddly error-prone hard-to-test work for comparatively little benefit.

Now, fixing it upstream in "autoregen", so that the errors _there_ are always helpful... that would sure rock.

Note: See TracTickets for help on using tickets.