Opened 7 years ago

Closed 7 years ago

#9698 closed enhancement (implemented)

Add source-ip + port to "New control connection opened" message

Reported by: Spider.007 Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Keywords: control-connection source-address tor-client easy
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


I just noticed an unexpected entry "New control connection opened" in my logs; I'm wondering who opened this connection (I have bound the controlport to a non-loopback address).

Could this message be extended with the source ip and address of this connection?

Child Tickets

Attachments (1)

control_log.diff (1.5 KB) - added by sigpipe 7 years ago.
Patch adding source IP address for control port connections

Download all attachments as: .zip

Change History (4)

comment:1 Changed 7 years ago by nickm

Keywords: tor-client easy added
Milestone: Tor: unspecified

Binding the control port to a non-loopback address is a really terrible idea; there is no encryption on the connection, and anybody who can sniff your network can take over your Tor process.

That said, I wouldn't mind adding a log for this.

Changed 7 years ago by sigpipe

Attachment: control_log.diff added

Patch adding source IP address for control port connections

comment:2 Changed 7 years ago by cypherpunks

Status: newneeds_review

comment:3 Changed 7 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Tweaked and merged as 4b8282e50cce1c63afbf7f501de1312a6f283387. Thanks!

Note: See TracTickets for help on using tickets.