Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#9700 closed defect (fixed)

current tor git fails to compile

Reported by: cypherpunks Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

current git compile fail on centos 5.9:

src/test/test.c: In function ‘test_onion_queues’:
src/test/test.c:412: error: ‘NTOR_ONIONSKIN_LEN’ undeclared (first use in this function)
src/test/test.c:412: error: (Each undeclared identifier is reported only once
src/test/test.c:412: error: for each function it appears in.)
src/test/test.c:412: warning: unused variable ‘buf2’
make[1]: * [src/test/src_test_test-test.o] Error 1
make[1]: Leaving directory `/root/Tor/tor'
make:
* [all] Error 2

this is with --disable-curve25519 since tor git fails to compile on centos 5.9 with other error without that

Child Tickets

Change History (6)

comment:1 Changed 6 years ago by arma

Component: - Select a componentTor
Keywords: tor-client added

Nick, this might be an 0.2.4 bug too.

I never quite sorted out the relationship between all the various ways to indicate having or not having ntor support. And I guess it shows in my unit tests. It might also show in my other patches.

comment:2 Changed 6 years ago by nickm

What errors do you get with --disable-curvee25519? Those should probably be in another ticket.

comment:3 in reply to:  2 Changed 6 years ago by nickm

Replying to nickm:

What errors do you get with --disable-curvee25519? Those should probably be in another ticket.

Ah, never mind. That's #9699.

comment:4 Changed 6 years ago by nickm

Resolution: fixed
Status: newclosed

0.2.4 still builds fine with --disable-curve25519; the tests are what needs the fix. Half a mo... There. Fixed in a0a855d586d99540277014ccd3.

comment:5 Changed 6 years ago by blueness

We're still hitting this with 0.2.4.21 in Gentoo. See the downstream bug:

https://bugs.gentoo.org/show_bug.cgi?id=505174

comment:6 Changed 6 years ago by nickm

Backported the fixed to 0.2.4.x as a83abcf5ee5cb8fe245bc97e089e082f62921194. I'd ordinarily ask for more review, but this is just moving an #include in a unit test file.

Note: See TracTickets for help on using tickets.