connection_consider_empty_{read,write}_buckets should not affect cpuworker connections

On IRC, skruffy points out that connection_consider_empty_{read,write}_buckets seem to affect local connections to cpuworkers. That can't possibly be right.

changed milestone to %Tor: 0.2.4.x-final

added 023-backport component::core tor/tor milestone::Tor: 0.2.4.x-final priority::high resolution::fixed status::closed tor-relay type::defect labels

There's a fix in branch "bug9731". I wonder if it breaks anything? Probably needs testing.

There's a less aggressive fix in branch "bug9731b" that applies the change only to cpuworker connections. That's a bit less likely to get unforseen consequences.

Trac:
Status: new to needs_review

bug9731b sounds ok for 0.2.4 if you're convinced it's a big deal for fast relays. If it's not a big deal, we should leave 0.2.4 alone.

I think bug9731 (for 0.2.5) might be improved by putting the 'if' at the top of the function, rather than after all the other computations that we're then going to ignore the result of.

I'm pretty sure that it's a big deal. Whenever your relay is ever exhausting its bandwidth bucket, it will fail to read or write data to cpuworkers. This increases the amount of time that cpuworkers will spend idle.

Now, an even better solution on the CPUworker situation would be a better, pipelining-based cpuworker implementation, like I did for my #9682 (moved) branch. But that's definitely 0.2.5 material.

Merged the b branch to 0.2.4, the main branch to 0.2.5, and made the tweak you suggested.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

mentioned in issue #11638 (moved)

moved to tpo/core/tor#9731 (closed)