Opened 6 years ago

Closed 5 years ago

#9732 closed task (duplicate)

Define SIGTERM behavior in pluggable transports spec

Reported by: dcf Owned by: asn
Priority: Medium Milestone:
Component: Circumvention/Pluggable transport Version:
Severity: Keywords: needs-spec-change
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

https://gitweb.torproject.org/torspec.git/blob/2f031167c120761fa2a3ef3e1dc62e630ab7372a:/proposals/180-pluggable-transport.txt says:

Proxies should respond to a single INT signal by closing their listener ports and not accepting any new connections, but keeping all connections open, then terminating when connections are all closed. Proxies should respond to a second INT signal by shutting down cleanly.

But it's silent on SIGTERM. When I /etc/init.d/tor stop on Debian, torctl kills the tor process with SIGTERM. I noticed because the super-proxy from comment:32:ticket:7167 starts subprocesses. It was properly killing the subprocesses on SIGINT, but not on SIGTERM.

My proposed wording:

Proxies should respond to a single TERM signal by closing their listener ports, closing all existing connections, and terminating.

Child Tickets

Change History (3)

comment:1 Changed 6 years ago by dcf

Component: - Select a componentPluggable transport
Owner: set to asn

comment:2 Changed 6 years ago by asn

Keywords: needs-spec-change added
Type: defecttask

comment:3 Changed 5 years ago by dcf

Resolution: duplicate
Status: newclosed

#15545 is going to change how shutdown works and document it.

Note: See TracTickets for help on using tickets.