Opened 5 years ago

Last modified 2 months ago

#9809 new enhancement

Re-disable Ctypes in TBB 7.0

Reported by: mikeperry Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-3.0, tbb-firefox-patch
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We disabled JS-Ctypes as part of #6152. Unfortunately, it broke a key component of Torbutton (#9790). Since we need to fix that and get a F17.0.9 release out ASAP, we need to re-enable ctypes for now until we can fix that and/or #9276.

Child Tickets

TicketTypeStatusOwnerSummary
#9276defectnewpdeRemove JS-Ctypes dependency from HTTPS-Everywhere
#9431defectclosedtbb-teamZotero addon depends on js-ctypes
#9790defectnewtbb-teamThe Torbutton startup observer component is sometimes not initialized
#10137defectnewtbb-teamESR24 won't work without ctypes being enabled

Change History (8)

comment:1 Changed 4 years ago by erinn

Keywords: tbb-firefox-patch added

comment:2 Changed 4 years ago by erinn

Component: Firefox Patch IssuesTor Browser
Owner: changed from mikeperry to tbb-team

comment:3 Changed 18 months ago by cypherpunks

Severity: Normal
Summary: Re-disable Ctypes in TBB 3.0Re-disable Ctypes in TBB 7.0

As Mike said:

We want to disable ctypes at compile time in TBB for sandboxing reasons

comment:4 Changed 2 months ago by ct

Didn't Mozilla fix it in esr60?

comment:5 in reply to:  4 ; Changed 2 months ago by gk

Replying to ct:

Didn't Mozilla fix it in esr60?

Fix what? Which Mozilla bug number do you have in mind?

comment:6 in reply to:  5 Changed 2 months ago by ct

Replying to gk:

Replying to ct:

Didn't Mozilla fix it in esr60?

Fix what?

What this ticket is about. Now it seems to be disabled by default (the only positive thing of switching to WebExtensions, heh).

Which Mozilla bug number do you have in mind?

For example, https://bugzilla.mozilla.org/show_bug.cgi?id=1215067?

comment:7 Changed 2 months ago by gk

That's for WebExtensions, yes, but the blocker here is actually #10137 and I am not aware that Firefox does work now without ctypes enabled, but would be happy to be proven wrong (ideally with links to Mozilla bugs that fixed this).

Last edited 2 months ago by gk (previous) (diff)

comment:8 in reply to:  7 Changed 2 months ago by ct

Replying to gk:

That's for WebExtensions, yes, but the blocker here is actually #10137 and I am not aware that Firefox does work now without ctypes enabled, but would be happy to be proven wrong (ideally with links to Mozilla bugs that fixed this).

Mozilla removed --disable-ctypes in https://hg.mozilla.org/mozilla-central/rev/2938c8a38f2b and support for anything other than WebExtensions in Firefox 57. So, this ticket and #6152 (despite its name), created to prevent arbitrary code execution in add-ons, look obsolete now.

Note: See TracTickets for help on using tickets.