Opened 7 years ago

Closed 6 years ago

#9870 closed defect (fixed)

Redundant "Your log may contain sensitive information" messages

Reported by: arma Owned by:
Priority: Low Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client 025-triaged
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

0.2.5.1-alpha when I start it with safelogging 0 and an info-level log says

Oct 01 21:02:26.050 [warn] Your log may contain sensitive information: you're logging more than "notice". Please log safely. Don't log unless it serves an important reason, and overwrite the log afterwards.
Oct 01 21:02:26.050 [notice] Not disabling debugger attaching for unprivileged users.
Oct 01 21:02:26.050 [warn] Your log may contain sensitive information - you disabled SafeLogging. Please log safely. Don't log unless it serves an important reason. Overwrite the log afterwards.

A) Is there any reason that first "may contain sensitive information" log is in options_act_reversible, and the second in options_act? I would think they should both be in options_act.

B) I think we should make only one log line show up if they both would. I'd pick the second one.

Child Tickets

Change History (4)

comment:1 Changed 7 years ago by nickm

Priority: normalminor
Status: newneeds_review

Another simple fix: branch bug9870. Please review.

comment:2 Changed 7 years ago by nickm

Keywords: tor-client 025-triaged added

comment:3 Changed 6 years ago by andrea

This is straightforward and appears correct to me. Merge away.

comment:4 Changed 6 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

merged; closing. Thanks!

Note: See TracTickets for help on using tickets.