Opened 6 years ago

Closed 3 weeks ago

#9898 closed enhancement (fixed)

Provide a clean fix for the strcmpi issue in mingw-w64 for NSPR if TBBs are built with rbm

Reported by: gk Owned by: tom
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, ff60-esr
Cc: tbb-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Now that #9084 is fixed (and is hopefully sticking) let's not forget to provide a clean solution to the _strcmpi issue outlined there.

Child Tickets

Change History (10)

comment:1 Changed 6 years ago by gk

Keywords: tbb-3.0 added; tbb3.0 removed

comment:2 Changed 5 years ago by erinn

Keywords: needs-triage added

comment:3 Changed 5 years ago by erinn

Component: Tor bundles/installationTor Browser
Owner: changed from erinn to tbb-team

comment:4 Changed 2 years ago by cypherpunks

Keywords: tbb-rbm added; tbb-3.0 needs-triage removed
Severity: Normal
Summary: Provide a clean fix for the _strcmpi issue in NSPR if TBBs are built with gitianProvide a clean fix for the strcmpi issue in mingw-w64 for NSPR if TBBs are built with rbm

There is no _strcmpi.
Deprecated POSIX functions strcmpi and stricmp were replaced with _stricmp (https://msdn.microsoft.com/en-us/library/ms235384.aspx).
For compatibility between M$ product versions, the library OLDNAMES.LIB maps old names to new names. For instance, strcmpi maps to _stricmp (https://docs.microsoft.com/en-us/cpp/c-runtime-library/backward-compatibility).
Therefore, https://sourceforge.net/p/mingw-w64/code/6179/ should be rewritten.

comment:5 Changed 2 years ago by gk

Keywords: ff59-esr added

comment:6 Changed 2 years ago by tom

Owner: changed from tbb-team to tom
Status: newassigned

I think I'm going to try and take this and fix it upstream.

comment:7 Changed 20 months ago by gk

Keywords: ff60-esr added; ff59-esr removed

Firefox 60 is the new ESR.

comment:8 Changed 18 months ago by gk

Cc: tbb-team added

Having this solved would still be pretty helpful. While the strcmpi issue is gone for ESR60 as we don't support Win XP anymore we have a new one with a missing _create_locale on Windows 7 only.

comment:9 in reply to:  8 Changed 18 months ago by cypherpunks

Replying to gk:

Having this solved would still be pretty helpful.

Yes, as Martin solved it for ucrt only.

While the strcmpi issue is gone for ESR60 as we don't support Win XP anymore

In ticket:9084#comment:25 you wrote something a little bit different.

we have a new one with a missing _create_locale on Windows 7 only.

Only that? Or is #23811 needed too?

comment:10 Changed 3 weeks ago by gk

Resolution: fixed
Status: assignedclosed

Using mingw-w64/clang for Firefox (and this NSPR) solves this issue.

Note: See TracTickets for help on using tickets.