Opened 6 years ago

Closed 6 years ago

#9927 closed enhancement (fixed)

Clients that use microdescriptors don't emit descriptor-fetching bootstrap events

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client 024-backport
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Now that I've fixed #9922 this bug became more apparent: when we use microdescriptors (which is the default), clients no longer emit any bootstrap messages between 45% ("I'm starting to fetch descriptors") and 80% ("I've got enough descriptors and now I'm going to try to connect to my guard relay").

Child Tickets

Change History (5)

comment:1 Changed 6 years ago by nickm

Keywords: 024-backport added
Status: newneeds_review

I did a fix against 0.2.4 as "bug9927". Please review?

comment:2 Changed 6 years ago by arma

looks plausible to me. is it tested?

the code touches stuff near where my 9922 patch touches. the conflict looks pretty easy to resolve though.

comment:3 Changed 6 years ago by nickm

Without this patch, the startup looks like:

Oct 08 12:14:06.000 [notice] We now have enough directory information to build circuits.
Oct 08 12:14:06.000 [notice] Bootstrapped 80%: Connecting to the Tor network.
Oct 08 12:14:07.000 [notice] Bootstrapped 85%: Finishing handshake with first hop.
Oct 08 12:14:08.000 [notice] Bootstrapped 90%: Establishing a Tor circuit.
Oct 08 12:14:09.000 [notice] Tor has successfully opened a circuit. Looks like client functionality is working.
Oct 08 12:14:09.000 [notice] Bootstrapped 100%: Done.

and no other bootstrapping events are reported.

With the patch, startup looks like:

Oct 08 12:12:37.000 [notice] I learned some more directory information, but not enough to build a circuit: We need more microdescriptors: we have 2/4502, and can only build 0% of likely paths. (We have 0% of guards bw, 0% of midpoint bw, and 0% of exit bw.)
Oct 08 12:12:37.000 [notice] Bootstrapped 50%: Loading relay descriptors.
Oct 08 12:12:37.000 [notice] Bootstrapped 52%: Loading relay descriptors.
Oct 08 12:12:37.000 [notice] Bootstrapped 54%: Loading relay descriptors.
Oct 08 12:12:37.000 [notice] Bootstrapped 57%: Loading relay descriptors.
Oct 08 12:12:37.000 [notice] Bootstrapped 59%: Loading relay descriptors.
Oct 08 12:12:37.000 [notice] I learned some more directory information, but not enough to build a circuit: We need more microdescriptors: we have 364/4502, and can only build 0% of likely paths. (We have 8% of guards bw, 10% of midpoint bw, and 10% of exit bw.)
Oct 08 12:12:38.000 [notice] Bootstrapped 61%: Loading relay descriptors.
Oct 08 12:12:38.000 [notice] Bootstrapped 64%: Loading relay descriptors.
Oct 08 12:12:38.000 [notice] Bootstrapped 66%: Loading relay descriptors.
Oct 08 12:12:38.000 [notice] Bootstrapped 68%: Loading relay descriptors.
Oct 08 12:12:38.000 [notice] Bootstrapped 71%: Loading relay descriptors.
Oct 08 12:12:38.000 [notice] Bootstrapped 73%: Loading relay descriptors.
Oct 08 12:12:38.000 [notice] Bootstrapped 75%: Loading relay descriptors.
Oct 08 12:12:38.000 [notice] Bootstrapped 78%: Loading relay descriptors.
Oct 08 12:12:39.000 [notice] We now have enough directory information to build circuits.
Oct 08 12:12:39.000 [notice] Bootstrapped 80%: Connecting to the Tor network.
Oct 08 12:12:39.000 [notice] Bootstrapped 90%: Establishing a Tor circuit.
Oct 08 12:12:41.000 [notice] Tor has successfully opened a circuit. Looks like client functionality is working.
Oct 08 12:12:41.000 [notice] Bootstrapped 100%: Done.

This looks right-ish to me, though this could be a bit verbose. Do we want this for 0.2.4 or for 0.2.5?

comment:4 Changed 6 years ago by arma

I'm a fan. Even in 0.2.4.

You're right that it's verbose.

But remember that each of these lines is also a control bootstrap status event instructing the progress bar in TBB to move forward. People who look at their logs can deal.

comment:5 Changed 6 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Okay, merged into 0.2.4 and later. The merge conflict was resolved by 66624ded3973ef9ad1e5fa5a3db53344186430e3.

Note: See TracTickets for help on using tickets.