Opened 7 years ago

Closed 6 years ago

#9958 closed defect (fixed)

We have two different places that calculate bootstrap progress

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

count_loading_descriptors_progress() calculates whether we've got enough descriptors using:

  count_usable_descriptors(&num_present, &num_usable, NULL,
                           consensus, get_options(), now, NULL, 0);

  fraction = num_present / (num_usable/4.);

whereas update_router_have_minimum_dir_info() does it using

    double paths = compute_frac_paths_available(consensus, options, now,
                                                &num_present, &num_usable,
                                                &status);

    if (paths < get_frac_paths_needed_for_circs(options,consensus)) {

We should do the second one in both places. (I have a patch.)

Child Tickets

Change History (5)

comment:1 Changed 7 years ago by arma

Status: newneeds_review

See my bug9958 branch.

I picked 0.2.5 even though this impacts bootstrapping progress reports, since we fixed the bulk of the issue in #9927, and also this fix makes it even louder.

My next thought is that we should add another ticket and another fix, to not log_notice the bootstrap progress so frequently, while still sending the bootstrap status events so the controller can move its progress bar forward.

comment:2 Changed 7 years ago by nickm

Merged to 0.2.5. Adding another ticket to limit bootstrap progress messages to the log.

comment:3 Changed 7 years ago by nickm

(In case we decide this should go in 0.2.4 for some zany reason, f96a8d5fa36b785632f54d929b9d70558e634f1a is the thing to cherry-pick.

comment:4 Changed 7 years ago by nickm

The new ticket is #9963

comment:5 Changed 6 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

It appears I merged this to 0.2.5, and nobody has asked for an 0.2.4 backport. Closing this ticket.

Note: See TracTickets for help on using tickets.