Opened 6 years ago

Closed 6 years ago

#9963 closed defect (fixed)

Limit descriptor-based bootstrap progress log messages

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client 024-backport 025-triaged
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When we fixed #9927, our notice log messages about bootstrapping progress became quite verbose. #9958 makes them even more so.

Let's send bootstrapping events controller with the same frequency as now, but log less aggressively.

Child Tickets

Change History (9)

comment:1 Changed 6 years ago by nickm

Status: newneeds_review

There's a patch against 0.2.4 (possibly overengineered) in "bug9963" in my public repository.

comment:2 Changed 6 years ago by arma

Yeah, that certainly looks overengineered. Why not just keep another static for when was the last progress point we did a log_notice, and decline to do a log_notice if our current progress isn't far enough along?

comment:3 Changed 6 years ago by nickm

Well, that approach would mean that we would sometimes not log the most recent bootstrapping step that we reached. So the logs might say we got up to step X, when really we only got up to step Y.

I guess we could say "log every change in 'status', but only log changes to 'progress' if their are magnitude of at least X". How would that be?

comment:4 Changed 6 years ago by arma

I think logging at 50%, 60%, 70% would be enough for people to follow along.

And heck, we could log the others at log_info if people need to debug.

comment:5 Changed 6 years ago by nickm

Keywords: 025-triaged added

I have a new branch, "bug9963_v2_024" that is much, much simpler. It works for me in testing. I say merge into 0.2.5, but let's not backport. (I've done the branch against 0.2.4 just in case we do decide that a backport is in order)

comment:6 Changed 6 years ago by nickm

Milestone: Tor: 0.2.5.x-finalTor: 0.2.4.x-final

This is simple enough that I'm comfortable merging it. I'm tired of seeing this bug every time I start Tor. Added to 0.2.5 and marked for backport review. (I recommend against the backport.)

comment:7 Changed 6 years ago by nickm

recommendation: no backport. merely annoying.

comment:8 Changed 6 years ago by arma

Agreed, no backport. We can give 0.2.5.x users something to look forward to. (Most users never see the logs anyway.)

comment:9 Changed 6 years ago by nickm

Milestone: Tor: 0.2.4.x-finalTor: 0.2.5.x-final
Resolution: fixed
Status: needs_reviewclosed

Seems like a cosmetic feature. Implemented in 0.2.5; not backporting.

Note: See TracTickets for help on using tickets.