Changes between Version 1 and Version 2 of org/meetings/2015SummerDevMeeting/CodeReviews


Ignore:
Timestamp:
Oct 2, 2015, 4:12:02 PM (4 years ago)
Author:
teor
Comment:

Code reviews session draft

Legend:

Unmodified
Added
Removed
Modified
  • org/meetings/2015SummerDevMeeting/CodeReviews

    v1 v2  
    33== What is the purpose of a code review? ==
    44
     5== Get the code ==
     6* Get branch
     7* Read diffs
     8* Compile (without warnings)
     9* make check (all success, no warnings in log)
     10* make test-network-all (requires chutney, all success)
     11* make check-spaces
     12
    513== Structure ==
    614== Style ==
    715== Security ==
     16
     17== Additional Tools ==
     18* static analysis
     19* dynamic sanitisers:
     20  * address
     21  * undefined behaviour
     22  * memory