wiki:org/meetings/2015SummerDevMeeting/CodeReviews

Version 2 (modified by teor, 4 years ago) (diff)

Code reviews session draft

Doing a Code Review

What is the purpose of a code review?

Get the code

  • Get branch
  • Read diffs
  • Compile (without warnings)
  • make check (all success, no warnings in log)
  • make test-network-all (requires chutney, all success)
  • make check-spaces

Structure

Style

Security

Additional Tools

  • static analysis
  • dynamic sanitisers:
    • address
    • undefined behaviour
    • memory