wiki:org/meetings/2015SummerDevMeeting/WritingCoreTorPatches

Writing Core Tor Patches

Design

  • Propose
  • Discuss
  • Analyse

This helps you work out whether the patch is useful and likely to be accepted.

Coding Style

  • match nearby code
  • 2-space indents
  • make check-spaces

Code

Unit Test

Changes File

Git Branch / Patch

  • Multiple commits

Trac Ticket

Search for an existing Trac ticket.

Create a ticket:

  • Type - choose defect / enhancement
  • Version - if it's a defect, and you know what version it appeared in, choose that version
  • Component - choose Tor

Code Review

Revise

  • Add commits to branch
  • Create a new branch to squash, rebase, or edit commits

Merge

Last modified 2 years ago Last modified on Oct 1, 2015, 8:34:08 AM