Opened 6 years ago

Closed 2 years ago

#10837 closed enhancement (wontfix)

Stop giving out version 2-style routerstatuses to controllers

Reported by: karsten Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: atagar Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

From #8913:

atagar points out that the control protocol still lets you ask for stuff in v2-formatted ways, and I believe that is still working. So maybe not all of v2 is in the attic yet.

Is this still the case? If so, we should probably remove the code that gives out version 2 descriptors to controllers. And the code that lets controllers ask for version 2 descriptors. And the respective parts in control-spec. Version 2 is dead.

Child Tickets

Change History (16)

comment:1 Changed 6 years ago by nickm

I don't think it's such a good idea to drop that code. (This isn't v2 descriptors, btw. It's v2-style routerstatus lines. They aren't taken directly from the networkstatus; they're generated based on our opinions of the nodes.)

Controller are allowed to use this info, and it's a comparatively small amount of code to keep it for now IMO. I'd like to have a better node-status export format, but it's not trivial to drop the "v2 routerstatus" format right now.

From a spec pov however, it would be nice to take just the v2 routerstatus format, document it by comparison to the v3 routerstatus format, and put that in control-spec.txt or in an appendix to it, so that we can retire dir-spec-v2.txt.

comment:3 Changed 5 years ago by nickm

Milestone: Tor: 0.2.5.x-finalTor: 0.2.6.x-final

comment:4 Changed 5 years ago by nickm

Milestone: Tor: 0.2.6.x-finalTor: 0.2.???

comment:5 Changed 4 years ago by nickm

Milestone: Tor: 0.2.???Tor: 0.2.7.x-final

These may be worth looking at for 0.2.7.

comment:6 Changed 4 years ago by nickm

Status: newassigned

comment:7 Changed 4 years ago by nickm

Keywords: 027-triaged-1-out added

Marking triaged-out items from first round of 0.2.7 triage.

comment:8 Changed 4 years ago by nickm

Milestone: Tor: 0.2.7.x-finalTor: 0.2.???

Make all non-needs_review, non-needs_revision, 027-triaged-1-out items belong to 0.2.???

comment:9 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:10 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:11 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:12 Changed 2 years ago by nickm

Keywords: 027-triaged-in added

comment:13 Changed 2 years ago by nickm

Keywords: 027-triaged-in removed

comment:14 Changed 2 years ago by nickm

Keywords: 027-triaged-1-out removed

comment:15 Changed 2 years ago by nickm

Status: assignednew

Change the status of all assigned/accepted Tor tickets with owner="" to "new".

comment:16 Changed 2 years ago by nickm

Resolution: wontfix
Severity: Normal
Status: newclosed
Summary: Stop giving out version 2 descriptors to controllersStop giving out version 2-style routerstatuses to controllers

The proper fix is not to stop providing the new format, but rather to add support for providing the new format.

Note: See TracTickets for help on using tickets.