Stop giving out version 2-style routerstatuses to controllers

From #8913 (moved):

atagar points out that the control protocol still lets you ask for stuff in v2-formatted ways, and I believe that is still working. So maybe not all of v2 is in the attic yet.

Is this still the case? If so, we should probably remove the code that gives out version 2 descriptors to controllers. And the code that lets controllers ask for version 2 descriptors. And the respective parts in control-spec. Version 2 is dead.

changed milestone to %Tor: unspecified

added component::core tor/tor milestone::Tor: unspecified priority::medium resolution::wontfix severity::normal status::closed type::enhancement labels

I don't think it's such a good idea to drop that code. (This isn't v2 descriptors, btw. It's v2-style routerstatus lines. They aren't taken directly from the networkstatus; they're generated based on our opinions of the nodes.)

Controller are allowed to use this info, and it's a comparatively small amount of code to keep it for now IMO. I'd like to have a better node-status export format, but it's not trivial to drop the "v2 routerstatus" format right now.

From a spec pov however, it would be nice to take just the v2 routerstatus format, document it by comparison to the v3 routerstatus format, and put that in control-spec.txt or in an appendix to it, so that we can retire dir-spec-v2.txt.

Actually, isn't it v3? I recall that we looked into this on...

https://trac.torproject.org/projects/tor/ticket/7953 https://gitweb.torproject.org/user/atagar/torspec.git/commitdiff/d2b7ebb

Trac:
Milestone: Tor: 0.2.5.x-final to Tor: 0.2.6.x-final

Trac:
Milestone: Tor: 0.2.6.x-final to Tor: 0.2.???

These may be worth looking at for 0.2.7.

Trac:
Milestone: Tor: 0.2.??? to Tor: 0.2.7.x-final

Trac:
Status: new to assigned

Marking triaged-out items from first round of 0.2.7 triage.

Trac:
Keywords: N/A deleted, 027-triaged-1-out added

Make all non-needs_review, non-needs_revision, 027-triaged-1-out items belong to 0.2.???

Trac:
Milestone: Tor: 0.2.7.x-final to Tor: 0.2.???

Milestone renamed

Trac:
Milestone: Tor: 0.2.??? to Tor: 0.3.???

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

Trac:
Keywords: N/A deleted, tor-03-unspecified-201612 added
Milestone: Tor: 0.3.??? to Tor: unspecified

Remove an old triaging keyword.

Trac:
Keywords: tor-03-unspecified-201612 deleted, N/A added

Trac:
Keywords: N/A deleted, 027-triaged-in added

Trac:
Keywords: 027-triaged-in deleted, N/A added

Trac:
Keywords: 027-triaged-1-out deleted, N/A added

Change the status of all assigned/accepted Tor tickets with owner="" to "new".

Trac:
Status: assigned to new

The proper fix is not to stop providing the new format, but rather to add support for providing the new format.

Trac:
Summary: Stop giving out version 2 descriptors to controllers to Stop giving out version 2-style routerstatuses to controllers
Sponsor: N/A to N/A
Resolution: N/A to wontfix
Severity: N/A to Normal
Status: new to closed
Reviewer: N/A to N/A

closed

moved to tpo/core/tor#10837 (closed)