#12161 closed defect (fixed)

launcher breaks arguments with spaces

Reported by: yar Owned by: erinn
Priority: normal Milestone:
Component: Tor bundles/installation Version:
Keywords: Cc: gk
Actual Points: Parent ID:
Points:

Description

I want to pass arguments with spaces to Firefox. For example: --class 'Tor Browser'

But the launch script uses an unquoted ${@} so it breaks.

This patch fixes it.

Related: https://trac.torproject.org/projects/tor/ticket/11102

Child Tickets

Attachments (1)

0001-launch-script-quote-arguments-with-spaces.patch (944 bytes) - added by yar 14 months ago.
patch to quote firefox arguments

Download all attachments as: .zip

Change History (4)

Changed 14 months ago by yar

patch to quote firefox arguments

comment:1 Changed 14 months ago by arma

  • Status changed from new to needs_review

comment:2 follow-up: Changed 14 months ago by arma

  • Cc gk added

(What is our plan tickets like this one? Or rather, who is the one who decides whether to merge them or leave them sitting here?)

comment:3 in reply to: ↑ 2 Changed 14 months ago by gk

  • Resolution set to fixed
  • Status changed from needs_review to closed

Replying to arma:

(What is our plan tickets like this one? Or rather, who is the one who decides whether to merge them or leave them sitting here?)

Not sure what you mean with "tickets like this one" but the usual policy is described in https://trac.torproject.org/projects/tor/wiki/doc/TorBrowser/Hacking:

In addition to this list, if you would like someone to review a patch, you should set the state of that ticket to "needs review" and tag it that that person's name, followed by the year, the month, and the letter 'R'. For example: MikePerry201311R.

That said I am more liberal than Mike who likes fancy keywords. Pinging me on IRC, writing me an email or just setting "needs_review" is usually enough for me. But, of course, using something like "GeorgKoppen201405" as a keyword works fine as well...
And that said I merged the patch to master (dbb4f9adac28b5be15ce55a02e0914918612b1f1) and maint-3.6 (d755aeec17412dda08c2ef352f1f45371e34aefd). Thanks!

Note: See TracTickets for help on using tickets.