Opened 7 months ago

Closed 6 months ago

#25067 closed enhancement (implemented)

Wrap types in protover.rs

Reported by: frewsxcv Owned by:
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: rust
Cc: coreyf+tor@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Introduce new wrapper types:

  • SupportedProtocols
  • Versions

Introduce a type alias:

  • Version (u32)

git branch: https://github.com/frewsxcv/tor/compare/master...frewsxcv-protover

Patch for https://trac.torproject.org/projects/tor/ticket/24030

Child Tickets

Change History (4)

comment:1 Changed 7 months ago by frewsxcv

Cc: coreyf+tor@… added
Status: newneeds_review

comment:2 Changed 7 months ago by gk

Component: - Select a componentCore Tor/Tor
Keywords: rust added

comment:3 Changed 6 months ago by nickm

Milestone: Tor: 0.3.3.x-final
Status: needs_reviewmerge_ready

This looks good to me! I'd like to merge it once we get a minimal fix for the issues of #25127.

comment:4 Changed 6 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

I've merged this with d9826b0a30f42754dc5764ce02c7b0271d996c92. Please let me know if I messed anything up, especially surrounding the conflicts with #25127. Thanks again for the patch!

Note: See TracTickets for help on using tickets.